From: "Luck, Tony" <tony.luck@intel.com>
To: "liuxp11@chinatelecom.cn" <liuxp11@chinatelecom.cn>,
"rafael@kernel.org" <rafael@kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"keescook@chromium.org" <keescook@chromium.org>,
"anton@enomsg.org" <anton@enomsg.org>,
"ccross@android.com" <ccross@android.com>,
"Moore, Robert" <robert.moore@intel.com>,
"lenb@kernel.org" <lenb@kernel.org>,
"james.morse@arm.com" <james.morse@arm.com>,
"bp@alien8.de" <bp@alien8.de>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"Huang, Ying" <ying.huang@intel.com>,
"gong.chen@linux.intel.com" <gong.chen@linux.intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: RE: [PATCH v4] ACPI: APEI: fix missing erst record id
Date: Fri, 8 Apr 2022 19:24:58 +0000 [thread overview]
Message-ID: <4208d2e15341432ba1137600b7e5b9ae@intel.com> (raw)
In-Reply-To: <1649406427-9357-1-git-send-email-liuxp11@chinatelecom.cn>
I think it might be a cleaner solution if you first implement a new function:
/*
* Like erst_read(), but look for a specific record type (by size and guid)
* also retry -ENOENT returns by skipping to next record_id
*/
ssize_t erst_read_record(u64 *record_id, struct cper_record_header *record,
size_t buflen, size_t recordlen, const guid_t *guid)
{
}
Step 2: Update apei_read_mce() and erst_reader() to use this function.
Step 3: Apply your erst_clear_cache() fix to the new function
-Tony
prev parent reply other threads:[~2022-04-08 19:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 8:27 [PATCH v4] ACPI: APEI: fix missing erst record id Liu Xinpeng
2022-04-08 19:24 ` Luck, Tony [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4208d2e15341432ba1137600b7e5b9ae@intel.com \
--to=tony.luck@intel.com \
--cc=anton@enomsg.org \
--cc=bp@alien8.de \
--cc=ccross@android.com \
--cc=dave.hansen@linux.intel.com \
--cc=gong.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=keescook@chromium.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuxp11@chinatelecom.cn \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox