Re: [PATCH] 2.6.10 Altix : ioc4 serial driver support

Matthew Wilcox
2004-12-22T20:33:32Z

On Wed, Dec 22, 2004 at 01:53:28PM -0600, Patrick Gefre wrote:
> Christoph Hellwig wrote:
> >So both claim the same PCI ID? In this case you need to creat a small
> >shim driver that exports a pseudo-bus to the serial and ide driver using
> >the driver model. You must never return an error from ->probe if you
> >actually use that particular device.
>
> Has this been done before ? Any example I can use ??

drivers/parisc/superio.c does something similar. I'm not sure I'd hold
it up as a shining example of how to write a driver ... constructive
criticism welcomed, thought there's some outstanding changes still in
the parisc tree that need to go upstream.

> Why is that ? Seems if kmalloc returns a void * and the left side is not, a
> casting is appropriate ?

void * is special and different. This is exactly why it was invented, btw.

--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain