Re: [PATCH] Altix : ioc4 serial driver support

Christoph Hellwig
2005-02-02T22:01:12Z

On Wed, Feb 02, 2005 at 02:36:15PM -0600, Patrick Gefre wrote:
> >Please kill ioc4_ide_init as it's completely unused and make
> >ioc4_serial_init
> >a normal module_init() handler in ioc4_serial, there's no need to call
> >them from the generic driver.
> >
>
> I want ioc4_serial_init called before pci_register_driver() if I make it a
> module_init() call I have no control over order ??

For the modular case it'd always be executed before because the module
must be loaded first, for the builtin case it'd depend on the link order.

Let's leave it as-is, it's probably safer.

> >Do you need to use ide_pci_register_driver? IOC4 doesn't have the legacy
> >IDE problems, and it's never used together with such devices in a system,
> >so a plain pci_register_driver should do it.
> >
>
> So ide_pci_register_driver is only for legacy devices with certain IDE
> problems - I think that is what you are saying (just trying to make sure
> I have it right) ??

Yes.