From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755047AbcBPL6Q (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Feb 2016 06:58:16 -0500
Received: from mout.kundenserver.de ([212.227.126.133]:55340 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754902AbcBPL6P (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Feb 2016 06:58:15 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Michal Simek <michal.simek@xilinx.com>,
        Nicolas Pitre <nicolas.pitre@linaro.org>,
        Josh Cartwright <josh.cartwright@ni.com>,
        Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
        Arun Chandran <achandran@mvista.com>,
        Russell King <linux@arm.linux.org.uk>, monstr@monstr.eu,
        linux-kernel@vger.kernel.org, Rob Herring <robherring2@gmail.com>,
        Steffen Trumtrar <s.trumtrar@pengutronix.de>,
        =?ISO-8859-1?Q?S=F6ren?= Brinkmann <soren.brinkmann@xilinx.com>
Subject: Re: [PATCH 1/3] ARM: zynq: Move early printk virtual address to vmalloc area
Date: Tue, 16 Feb 2016 12:57:30 +0100
Message-ID: <4209295.YSuxZXZMPH@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <67c9013fc61f53515934b54847a05df8b8e1504a.1455552315.git.michal.simek@xilinx.com>
References: <67c9013fc61f53515934b54847a05df8b8e1504a.1455552315.git.michal.simek@xilinx.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:SsI9OynZNRhy9QSd+HU+xxkg3hJ0hMLL076VS4BJGfB9AeHO9lu
 JTsb9NhCXuhrbRg98CnO4uB+t46CrfOlHH1wEnzelUoPi1+fnvPZqwPBo5I/UhWDnVPWi0v
 QoofyAIUW+yB1HE5g7vI41WTNhVWuSKx+pmQDOtQqLGAhtFAt6a1AKwuMzufvC83NXYHO0X
 0HvJSPpnOixgWpqhTUCEA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:t6kj6wpTtys=:pXcjo2h8F91q3qXuItRyhO
 F17fcYiTcodxeCB15uIjgdLBCUEJqiZnCFWoifS8T6gdOk58pdlHGUvXEBwNfvogt5GALXWku
 goS6jUlznYSE3hjV0yGkyX1roHY1ouIienIWD8MRIN5zoDKwaJhyIpzMYLQIj2Jwv8eUHimNS
 t5DAurUbyWH1hLeL8gkZiHf5WnHC4FpE578LU9qvuBMH12KN6ahqLpEJX8VH1HClBdu2sV2ps
 i0nSLCUR3NVAsfddsz/ypSRHx8j7J1ag8o0oPUAG6oAO0dVd9jKoo/kexOfgDNB9+IJEuw87s
 mEXv7TjEsuY14O7VIrYJDwdImYo/Orb15QeyHl5hUtaoSNbuAJXldIdU9nIk1T3NOc6d8oNir
 6uyag6yxv2a8ggHycKoxiXmFO8Cd/78BHfRT1yszSr71ZmCqdvmGM4enKHvBi/uCKE0L1+391
 5MYmWfMc2JZNNUBK0AdGF+vB1K/g12E1l6Qe3OrVPXK4a+LG89hMHIwDq9xBYro1yzop7TFxF
 hVsTEbi1A9EBSzxum8Ao6hRphHdk8RPFkd2sczJycAUK6nti9WlkY3hcwkh0YZ0mUYnhZIXxM
 cgvLcSm7NLzxyoP9x3tooZvHbZ65DoGasVos3cg+pXES3UzB722Pszi3IOfM+iauQV6OlqFHr
 4DyMhch6mVEf/2ek18gMv1j6iXUqq5+vo1fIFsXw+eo8DutPlWIIOXXvgdSOdid+fioVJ97IS
 PmA1Lb4eUcHLdyit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday 15 February 2016 17:05:17 Michal Simek wrote:
> The patch
> "ARM: 8432/1: move VMALLOC_END from 0xff000000 to 0xff800000"
> (sha1: 6ff0966052c46efb53980b8a1add2e7b49c9f560)
> has moved also start of VMALLOC area because size didn't change.
> That's why origin location of vmalloc was
>    vmalloc : 0xf0000000 - 0xff000000   ( 240 MB)
> and now is
>    vmalloc : 0xf0800000 - 0xff800000   ( 240 MB)
> 
> That's why uart virtual addresses need to be changed to reflect this new
> memory setup. Starting address should be vmalloc start address.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

All three patches look good to me,

Acked-by: Arnd Bergmann <arnd@arndb.de>

I would like to hear back from Nico on this though: is this an expected
outcome of your patch, or is it something you had not considered at
all?

Do we need to audit all platforms for other instances of the same
problem? I see for instance

static struct map_desc jornada720_io_desc[] __initdata = {
        {       /* Epson registers */
                .virtual        = 0xf0000000,
                .pfn            = __phys_to_pfn(EPSONREGSTART),
                .length         = EPSONREGLEN,
                .type           = MT_DEVICE
        }, {    /* Epson frame buffer */

in arch/arm/mach-sa1100/jornada720.c. Could this have the same problem?

I would guess that only machines with 768MB of RAM (or more) can run
into the bug.

	Arnd