* [PATCH 2/5] sonypi: add another HELP button event
@ 2005-02-10 15:45 Stelian Pop
2005-02-10 17:31 ` Daniel K.
0 siblings, 1 reply; 3+ messages in thread
From: Stelian Pop @ 2005-02-10 15:45 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: Andrew Morton, Linus Torvalds
===================================================================
Add another HELP button event.
Increment the version number.
Signed-off-by: Stelian Pop <stelian@popies.net>
===================================================================
sonypi.h | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
===================================================================
Index: drivers/char/sonypi.h
===================================================================
--- a/drivers/char/sonypi.h (revision 26539)
+++ b/drivers/char/sonypi.h (revision 26540)
@@ -1,7 +1,7 @@
/*
* Sony Programmable I/O Control Device driver for VAIO
*
- * Copyright (C) 2001-2004 Stelian Pop <stelian@popies.net>
+ * Copyright (C) 2001-2005 Stelian Pop <stelian@popies.net>
*
* Copyright (C) 2001-2002 Alcôve <www.alcove.com>
*
@@ -36,7 +36,7 @@
#ifdef __KERNEL__
-#define SONYPI_DRIVER_VERSION "1.25"
+#define SONYPI_DRIVER_VERSION "1.26"
#define SONYPI_DEVICE_MODEL_TYPE1 1
#define SONYPI_DEVICE_MODEL_TYPE2 2
@@ -330,6 +330,7 @@ struct sonypi_eventtypes {
{ SONYPI_DEVICE_MODEL_TYPE2, 0x08, SONYPI_PKEY_MASK, sonypi_pkeyev },
{ SONYPI_DEVICE_MODEL_TYPE2, 0x11, SONYPI_BACK_MASK, sonypi_backev },
{ SONYPI_DEVICE_MODEL_TYPE2, 0x08, SONYPI_HELP_MASK, sonypi_helpev },
+ { SONYPI_DEVICE_MODEL_TYPE2, 0x21, SONYPI_HELP_MASK, sonypi_helpev },
{ SONYPI_DEVICE_MODEL_TYPE2, 0x21, SONYPI_ZOOM_MASK, sonypi_zoomev },
{ SONYPI_DEVICE_MODEL_TYPE2, 0x20, SONYPI_THUMBPHRASE_MASK, sonypi_thumbphraseev },
{ SONYPI_DEVICE_MODEL_TYPE2, 0x31, SONYPI_MEMORYSTICK_MASK, sonypi_memorystickev },
--
Stelian Pop <stelian@popies.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/5] sonypi: add another HELP button event
2005-02-10 15:45 [PATCH 2/5] sonypi: add another HELP button event Stelian Pop
@ 2005-02-10 17:31 ` Daniel K.
2005-02-11 11:24 ` Stelian Pop
0 siblings, 1 reply; 3+ messages in thread
From: Daniel K. @ 2005-02-10 17:31 UTC (permalink / raw)
To: Stelian Pop; +Cc: Linux Kernel Mailing List, Andrew Morton, Linus Torvalds
Stelian Pop wrote:
> ===================================================================
>
> Add another HELP button event.
> Increment the version number.
>
>
> Index: drivers/char/sonypi.h
> ===================================================================
> --- a/drivers/char/sonypi.h (revision 26539)
> +++ b/drivers/char/sonypi.h (revision 26540)
> @@ -330,6 +330,7 @@ struct sonypi_eventtypes {
> { SONYPI_DEVICE_MODEL_TYPE2, 0x08, SONYPI_PKEY_MASK, sonypi_pkeyev },
> { SONYPI_DEVICE_MODEL_TYPE2, 0x11, SONYPI_BACK_MASK, sonypi_backev },
> { SONYPI_DEVICE_MODEL_TYPE2, 0x08, SONYPI_HELP_MASK, sonypi_helpev },
> + { SONYPI_DEVICE_MODEL_TYPE2, 0x21, SONYPI_HELP_MASK, sonypi_helpev },
> { SONYPI_DEVICE_MODEL_TYPE2, 0x21, SONYPI_ZOOM_MASK, sonypi_zoomev },
> { SONYPI_DEVICE_MODEL_TYPE2, 0x20, SONYPI_THUMBPHRASE_MASK, sonypi_thumbphraseev },
> { SONYPI_DEVICE_MODEL_TYPE2, 0x31, SONYPI_MEMORYSTICK_MASK, sonypi_memorystickev },
I suspect you should simply replace the '0x08' line as it was left over
from my earlier patch introducing EVTYPE_OFFSET. At that time all the
values were 0x08, most was updated, but a few were not, due to
unsuficcient data.
Daniel K.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/5] sonypi: add another HELP button event
2005-02-10 17:31 ` Daniel K.
@ 2005-02-11 11:24 ` Stelian Pop
0 siblings, 0 replies; 3+ messages in thread
From: Stelian Pop @ 2005-02-11 11:24 UTC (permalink / raw)
To: Daniel K.; +Cc: Linux Kernel Mailing List, Andrew Morton, Linus Torvalds
On Thu, Feb 10, 2005 at 05:31:05PM +0000, Daniel K. wrote:
> > { SONYPI_DEVICE_MODEL_TYPE2, 0x08, SONYPI_HELP_MASK, sonypi_helpev },
> > + { SONYPI_DEVICE_MODEL_TYPE2, 0x21, SONYPI_HELP_MASK, sonypi_helpev },
>
> I suspect you should simply replace the '0x08' line as it was left over
> from my earlier patch introducing EVTYPE_OFFSET. At that time all the
> values were 0x08, most was updated, but a few were not, due to
> unsuficcient data.
I think you're right. I've queued this for a later update.
Thanks.
Stelian.
--
Stelian Pop <stelian@popies.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-02-11 11:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-10 15:45 [PATCH 2/5] sonypi: add another HELP button event Stelian Pop
2005-02-10 17:31 ` Daniel K.
2005-02-11 11:24 ` Stelian Pop
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox