[PATCH 2/5] sonypi: add another HELP button event

[PATCH 2/5] sonypi: add another HELP button event

[Stelian Pop]

===================================================================

Add another HELP button event.
Increment the version number.

Signed-off-by: Stelian Pop <stelian@popies.net>

===================================================================

 sonypi.h |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

===================================================================

Index: drivers/char/sonypi.h
===================================================================
--- a/drivers/char/sonypi.h	(revision 26539)
+++ b/drivers/char/sonypi.h	(revision 26540)
@@ -1,7 +1,7 @@
 /*
  * Sony Programmable I/O Control Device driver for VAIO
  *
- * Copyright (C) 2001-2004 Stelian Pop <stelian@popies.net>
+ * Copyright (C) 2001-2005 Stelian Pop <stelian@popies.net>
  *
  * Copyright (C) 2001-2002 Alcôve <www.alcove.com>
  *
@@ -36,7 +36,7 @@
 
 #ifdef __KERNEL__
 
-#define SONYPI_DRIVER_VERSION	 "1.25"
+#define SONYPI_DRIVER_VERSION	 "1.26"
 
 #define SONYPI_DEVICE_MODEL_TYPE1	1
 #define SONYPI_DEVICE_MODEL_TYPE2	2
@@ -330,6 +330,7 @@ struct sonypi_eventtypes {
 	{ SONYPI_DEVICE_MODEL_TYPE2, 0x08, SONYPI_PKEY_MASK, sonypi_pkeyev },
 	{ SONYPI_DEVICE_MODEL_TYPE2, 0x11, SONYPI_BACK_MASK, sonypi_backev },
 	{ SONYPI_DEVICE_MODEL_TYPE2, 0x08, SONYPI_HELP_MASK, sonypi_helpev },
+	{ SONYPI_DEVICE_MODEL_TYPE2, 0x21, SONYPI_HELP_MASK, sonypi_helpev },
 	{ SONYPI_DEVICE_MODEL_TYPE2, 0x21, SONYPI_ZOOM_MASK, sonypi_zoomev },
 	{ SONYPI_DEVICE_MODEL_TYPE2, 0x20, SONYPI_THUMBPHRASE_MASK, sonypi_thumbphraseev },
 	{ SONYPI_DEVICE_MODEL_TYPE2, 0x31, SONYPI_MEMORYSTICK_MASK, sonypi_memorystickev },
-- 
Stelian Pop <stelian@popies.net>

Re: [PATCH 2/5] sonypi: add another HELP button event

[Daniel K.]

Stelian Pop wrote:
> ===================================================================
> 
> Add another HELP button event.
> Increment the version number.
> 

> 
> Index: drivers/char/sonypi.h
> ===================================================================
> --- a/drivers/char/sonypi.h	(revision 26539)
> +++ b/drivers/char/sonypi.h	(revision 26540)

> @@ -330,6 +330,7 @@ struct sonypi_eventtypes {
>  	{ SONYPI_DEVICE_MODEL_TYPE2, 0x08, SONYPI_PKEY_MASK, sonypi_pkeyev },
>  	{ SONYPI_DEVICE_MODEL_TYPE2, 0x11, SONYPI_BACK_MASK, sonypi_backev },
>  	{ SONYPI_DEVICE_MODEL_TYPE2, 0x08, SONYPI_HELP_MASK, sonypi_helpev },
> +	{ SONYPI_DEVICE_MODEL_TYPE2, 0x21, SONYPI_HELP_MASK, sonypi_helpev },
>  	{ SONYPI_DEVICE_MODEL_TYPE2, 0x21, SONYPI_ZOOM_MASK, sonypi_zoomev },
>  	{ SONYPI_DEVICE_MODEL_TYPE2, 0x20, SONYPI_THUMBPHRASE_MASK, sonypi_thumbphraseev },
>  	{ SONYPI_DEVICE_MODEL_TYPE2, 0x31, SONYPI_MEMORYSTICK_MASK, sonypi_memorystickev },

I suspect you should simply replace the '0x08' line as it was left over
from my earlier patch introducing EVTYPE_OFFSET. At that time all the
values were 0x08, most was updated, but a few were not, due to
unsuficcient data.

Daniel K.

Re: [PATCH 2/5] sonypi: add another HELP button event

[Stelian Pop]

On Thu, Feb 10, 2005 at 05:31:05PM +0000, Daniel K. wrote:

> >  	{ SONYPI_DEVICE_MODEL_TYPE2, 0x08, SONYPI_HELP_MASK, sonypi_helpev },
> > +	{ SONYPI_DEVICE_MODEL_TYPE2, 0x21, SONYPI_HELP_MASK, sonypi_helpev },
> 
> I suspect you should simply replace the '0x08' line as it was left over
> from my earlier patch introducing EVTYPE_OFFSET. At that time all the
> values were 0x08, most was updated, but a few were not, due to
> unsuficcient data.

I think you're right. I've queued this for a later update. 

Thanks.

Stelian.
-- 
Stelian Pop <stelian@popies.net>