public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pci/quirks.c: unhide SMBus device on Samsung P35 laptop
@ 2005-02-17  2:49 Carl-Daniel Hailfinger
  2005-02-17 23:17 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Carl-Daniel Hailfinger @ 2005-02-17  2:49 UTC (permalink / raw)
  To: Linux Kernel Mailing List; +Cc: Greg KH

Hi,

this patch is needed to make the SMBus device on my Samsung P35
laptop visible. By default, it doesn't appear as a pci device.

Patch tested, works perfectly for me. Please apply.

Regards,
Carl-Daniel
-- 
http://www.hailfinger.org/

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2005@gmx.net>

===== drivers/pci/quirks.c 1.68 vs edited =====
--- 1.68/drivers/pci/quirks.c	2005-02-03 07:42:20 +01:00
+++ edited/drivers/pci/quirks.c	2005-02-16 23:50:49 +01:00
@@ -801,6 +801,12 @@
 			case 0x12bc: /* HP D330L */
 				asus_hides_smbus = 1;
 			}
+       } else if (unlikely(dev->subsystem_vendor == PCI_VENDOR_ID_SAMSUNG)) {
+               if (dev->device ==  PCI_DEVICE_ID_INTEL_82855PM_HB)
+                       switch(dev->subsystem_device) {
+                       case 0xC00C: /* Samsung P35 notebook */
+                               asus_hides_smbus = 1;
+                       }
 	}
 }
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL,	PCI_DEVICE_ID_INTEL_82845_HB,	asus_hides_smbus_hostbridge );
===== include/linux/pci_ids.h 1.200 vs edited =====
--- 1.200/include/linux/pci_ids.h	2005-01-31 07:33:43 +01:00
+++ edited/include/linux/pci_ids.h	2005-02-16 23:48:09 +01:00
@@ -1905,6 +1905,8 @@
 #define PCI_DEVICE_ID_OXSEMI_16PCI954PP	0x9513
 #define PCI_DEVICE_ID_OXSEMI_16PCI952	0x9521

+#define PCI_VENDOR_ID_SAMSUNG		0x144d
+
 #define PCI_VENDOR_ID_AIRONET		0x14b9
 #define PCI_DEVICE_ID_AIRONET_4800_1	0x0001
 #define PCI_DEVICE_ID_AIRONET_4800	0x4500 // values switched?  see


^ permalink raw reply	[flat|nested] 3+ messages in thread
* [PATCH] PCI: allow x86_64 to do pci express
@ 2005-03-04 20:53 Greg KH
  2005-03-04 20:53 ` [PATCH] pci/quirks.c: unhide SMBus device on Samsung P35 laptop Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2005-03-04 20:53 UTC (permalink / raw)
  To: linux-kernel, linux-pci; +Cc: ak

ChangeSet 1.1998.11.19, 2005/02/17 15:06:16-08:00, ak@muc.de

[PATCH] PCI: allow x86_64 to do pci express

On Mon, Feb 14, 2005 at 10:47:01AM +0100, Piotr Kaczuba wrote:
> On Mon, Feb 14, 2005 at 10:18:43AM +0100, Andi Kleen wrote:
> > Piotr Kaczuba <pepe@attika.ath.cx> writes:
> > > Is there a reason why "PCI access mode" config option isn't available for
> > > x86_64? Due to this, PCIE config options aren't available either.
> >
> > There is no 64bit PCI BIOS, so access is always direct.
> >
> > I assume you mean mmconfig access with "PCIE config options", that is
> > a separate config option and available.
>
> I mean the PCIEPORTBUS option which depends on PCI_GOMMCONFIG or
> PCI_GOANY. I assume that due to PCI_MMCONFIG / PCI_GOMMCONFIG mismatch
> it's not available on x86_64.

Ok, that's a bug in PCIEPORTBUS.  Best is probably to
completely remove the dependency, it doesn't make much sense
(the code has to handle the case of mmconfig not being available at
runtime anyways)

Remove bogus dependency in PCI Express root driver.

Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>


 drivers/pci/pcie/Kconfig |    1 -
 1 files changed, 1 deletion(-)


diff -Nru a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
--- a/drivers/pci/pcie/Kconfig	2005-03-04 12:42:04 -08:00
+++ b/drivers/pci/pcie/Kconfig	2005-03-04 12:42:04 -08:00
@@ -3,7 +3,6 @@
 #
 config PCIEPORTBUS
 	bool "PCI Express support"
-	depends on PCI_GOMMCONFIG || PCI_GOANY
 	default n
 
 	---help---


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-03-05  4:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-17  2:49 [PATCH] pci/quirks.c: unhide SMBus device on Samsung P35 laptop Carl-Daniel Hailfinger
2005-02-17 23:17 ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2005-03-04 20:53 [PATCH] PCI: allow x86_64 to do pci express Greg KH
2005-03-04 20:53 ` [PATCH] pci/quirks.c: unhide SMBus device on Samsung P35 laptop Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox