From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix possible race with 4level-fixup.h
Date: Thu, 17 Feb 2005 20:00:15 +1100 [thread overview]
Message-ID: <42145D1F.5000301@yahoo.com.au> (raw)
In-Reply-To: <1108629648.5425.73.camel@gaston>
Benjamin Herrenschmidt wrote:
>>>Index: linux-work/include/asm-generic/4level-fixup.h
>>>===================================================================
>>>--- linux-work.orig/include/asm-generic/4level-fixup.h 2005-01-24 17:09:49.000000000 +1100
>>>+++ linux-work/include/asm-generic/4level-fixup.h 2005-02-17 18:10:38.000000000 +1100
>>>@@ -24,7 +24,7 @@
>>> #define pud_bad(pud) 0
>>> #define pud_present(pud) 1
>>> #define pud_ERROR(pud) do { } while (0)
>>>-#define pud_clear(pud) do { } while (0)
>>>+#define pud_clear(pud) pgd_clear((pgd_t *)(pud))
>>>
>>
>>Just a small nit - no cast needed here.
>
>
> Well, do you know ? pud is a pud_t* and the arch is free to implement
> pgd_clear as an inline with strong typing no ?
>
Yeah but if you're using the 4level-fixup.h header, then you get
#define pud_t pgd_t
Not that I really mind, but in this header we've just avoided
doing casts for that reason.
Nick
prev parent reply other threads:[~2005-02-17 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-17 7:19 [PATCH] Fix possible race with 4level-fixup.h Benjamin Herrenschmidt
2005-02-17 8:33 ` Nick Piggin
2005-02-17 8:40 ` Benjamin Herrenschmidt
2005-02-17 9:00 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42145D1F.5000301@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox