From: Jeff Garzik <jgarzik@pobox.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Christophe Lucas <c.lucas@ifrance.com>,
kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/char/watchdog/* : pci_request_regions
Date: Thu, 17 Feb 2005 13:49:12 -0500 [thread overview]
Message-ID: <4214E728.3030501@pobox.com> (raw)
In-Reply-To: <20050214151244.GF29917@parcelfarce.linux.theplanet.co.uk>
Matthew Wilcox wrote:
> On Mon, Feb 14, 2005 at 04:01:11PM +0100, Christophe Lucas wrote:
>
>>If PCI request regions fails, then someone else is using the
>>hardware we wish to use. For that one case, calling
>>pci_disable_device() is rather rude.
>>See : http://www.ussg.iu.edu/hypermail/linux/kernel/0502.1/1061.html
>
>
> Actually, that isn't necessarily true. If the request_regions call fails,
> that can mean there's a resource conflict. If so, leaving the device
> enabled is the worst possible thing to do as we'll now have two devices
> trying to respond to the same io accesses.
Incorrect. If request_region() fails, drivers are coded to _not_ touch
the hardware. That's the entire purpose of the whole charade: to avoid
having two devices responding to the same io accesses.
If your driver is talking to the hardware after request_region() fails,
it is BROKEN plain and simple.
Jeff
next prev parent reply other threads:[~2005-02-17 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050214150111.GH20620@rhum.iomeda.fr>
2005-02-14 15:12 ` [KJ] [PATCH] drivers/char/watchdog/* : pci_request_regions Matthew Wilcox
2005-02-17 18:49 ` Jeff Garzik [this message]
2005-02-17 19:04 ` Matthew Wilcox
2005-02-17 19:22 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4214E728.3030501@pobox.com \
--to=jgarzik@pobox.com \
--cc=c.lucas@ifrance.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox