From: Jay Lan <jlan@sgi.com>
To: LKML <linux-kernel@vger.kernel.org>,
Christoph Lameter <clameter@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>
Subject: initialize_acct_integrals
Date: Fri, 18 Feb 2005 06:15:59 -0800 [thread overview]
Message-ID: <4215F89F.9050801@sgi.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 624 bytes --]
Hi Andrew,
The new "move-accounting-function-calls-out-of-critical-vm-code-paths"
patch in 2.6.11-rc3-mm2 was different from the code i tested.
In particular, it mistakenly dropped the accounting routine calls
in fs/exec.c. The calls in do_execve() are needed to properly
initialize accounting fields. Specifically, the tsk->acct_stimexpd
needs to be initialized to tsk->stime.
I have discussed this with Christoph Lameter and he gave me full
blessings to bring the calls back.
This initialize_acct_integrals patch was generated against
2.6.11-rc3-mm2 to fix the problem. Thanks!
Signed-off-by: Jay Lan <jlan@sgi.com>
[-- Attachment #2: initialize_acct_integrals --]
[-- Type: text/plain, Size: 421 bytes --]
Index: linux/fs/exec.c
===================================================================
--- linux.orig/fs/exec.c 2005-02-17 19:24:45.785343748 -0800
+++ linux/fs/exec.c 2005-02-18 05:45:19.868493728 -0800
@@ -1193,6 +1193,8 @@ int do_execve(char * filename,
/* execve success */
security_bprm_free(bprm);
+ acct_update_integrals(current);
+ update_mem_hiwater(current);
kfree(bprm);
return retval;
}
reply other threads:[~2005-02-18 14:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4215F89F.9050801@sgi.com \
--to=jlan@sgi.com \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox