From: Paulo Marques <pmarques@grupopie.com>
To: Paul Fulghum <paulkf@microgate.com>
Cc: franck.bui-huu@innova-card.com, linux-kernel@vger.kernel.org
Subject: Re: [TTY] 2 points seems strange to me.
Date: Fri, 18 Feb 2005 15:24:24 +0000 [thread overview]
Message-ID: <421608A8.60204@grupopie.com> (raw)
In-Reply-To: <4216068E.90205@microgate.com>
Paul Fulghum wrote:
> Paulo Marques wrote:
>
>> Paul Fulghum wrote:
>>
>>> No, it limits the size to 80 bytes,
>>> which is the size of buf.
>>>
>>> sizeof returns the size of the char array buf[80]
>>> (standard C)
>>
>>
>> Looking at the code, I think Franck is right. buf is a "const unsigned
>> char *" for which sizeof(buf) is the size of a pointer.
>
>
> What kernel version are you looking at?
> I'm looking at 2.4.20 n_tty.c opost_block() and
> buf is a char array.
Oops, this should have been clarified sooner...
I was looking at a 2.6.11-rc2 tree I have hanging around here. So maybe
the "buf" type was changed and the condition remained, and that produced
the bug.
--
Paulo Marques - www.grupopie.com
All that is necessary for the triumph of evil is that good men do nothing.
Edmund Burke (1729 - 1797)
next prev parent reply other threads:[~2005-02-18 15:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-17 17:51 Problems with dma_mmap_writecombine on mach-pxa Frank Buss
2005-02-17 18:12 ` Russell King
2005-02-17 19:14 ` Frank Buss
2005-02-17 19:58 ` Russell King
2005-02-18 9:30 ` [TTY] 2 points seems strange to me Franck Bui-Huu
2005-02-18 14:58 ` Paul Fulghum
2005-02-18 15:08 ` Paulo Marques
2005-02-18 15:15 ` Paul Fulghum
2005-02-18 15:24 ` Paulo Marques [this message]
2005-02-18 15:24 ` linux-os
2005-02-18 15:27 ` Paulo Marques
2005-02-18 16:14 ` Franck Bui-Huu
2005-02-18 15:19 ` linux-os
2005-02-18 16:29 ` Franck Bui-Huu
2005-02-18 16:41 ` Paul Fulghum
2005-02-18 18:07 ` Problems with dma_mmap_writecombine on mach-pxa Frank Buss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=421608A8.60204@grupopie.com \
--to=pmarques@grupopie.com \
--cc=franck.bui-huu@innova-card.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulkf@microgate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox