From: Rene Herman <rene.herman@keyaccess.nl>
To: Roland Dreier <roland@topspin.com>
Cc: Vicente Feito <vicente.feito@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: workqueue - process context
Date: Sat, 19 Feb 2005 15:31:48 +0100 [thread overview]
Message-ID: <42174DD4.9010506@keyaccess.nl> (raw)
In-Reply-To: <52is4ptae0.fsf@topspin.com>
Roland Dreier wrote:
> Not destroying its workqueue is a bug in the module just like any
> other resource leak. It's analogous to a module allocating some
> memory with kmalloc() and not calling kfree() when it's unloaded.
Except though that with kmalloc() it's indeed just a leak while in this
case things might blow up violently if run_workqueue() later accesses a
workqueue_struct (or work_struct) which is already gone as part of the
modules' datasection, for example. That's to say, if I'm reading this
right...
I have no idea about the module refcounting stuff. Is there a chance
that create_workqueue() could increase a reference somewhere so that the
module wouldn't be allowed to unload untill after a destroy_workqueue()?
Rene.
next prev parent reply other threads:[~2005-02-19 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-19 1:48 workqueue - process context Vicente Feito
2005-02-19 4:57 ` Roland Dreier
2005-02-19 2:02 ` Vicente Feito
2005-02-19 5:03 ` Roland Dreier
2005-02-19 14:31 ` Rene Herman [this message]
2005-02-19 16:19 ` Roland Dreier
2005-02-19 16:52 ` Rene Herman
-- strict thread matches above, loose matches on Subject: below --
2005-02-19 2:38 Vicente Feito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42174DD4.9010506@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@topspin.com \
--cc=vicente.feito@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox