From: Jeff Garzik <jgarzik@pobox.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-net@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/net/lp486e.c: make some code static
Date: Sun, 20 Feb 2005 20:47:14 -0500 [thread overview]
Message-ID: <42193DA2.9050606@pobox.com> (raw)
In-Reply-To: <20050217205454.GI6194@stusta.de>
Adrian Bunk wrote:
> This patch makes some needlessly global code static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> drivers/net/lp486e.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> --- linux-2.6.11-rc3-mm2-full/drivers/net/lp486e.c.old 2005-02-16 16:08:34.000000000 +0100
> +++ linux-2.6.11-rc3-mm2-full/drivers/net/lp486e.c 2005-02-16 16:15:33.000000000 +0100
> @@ -112,8 +112,10 @@
> CmdDiagnose = 7
> };
>
> -char *CUcmdnames[8] = { "NOP", "IASetup", "Configure", "MulticastList",
> - "Tx", "TDR", "Dump", "Diagnose" };
> +#if 0
> +static char *CUcmdnames[8] = { "NOP", "IASetup", "Configure", "MulticastList",
> + "Tx", "TDR", "Dump", "Diagnose" };
> +#endif
Need const.
Jeff
next prev parent reply other threads:[~2005-02-21 1:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-17 20:54 [2.6 patch] drivers/net/lp486e.c: make some code static Adrian Bunk
2005-02-21 1:47 ` Jeff Garzik [this message]
2005-02-21 14:47 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42193DA2.9050606@pobox.com \
--to=jgarzik@pobox.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox