Re: [2.6.11-rc4-mm1 patch] drivers/scsi/arcmsr/arcmsr.c cleanups

Christoph Hellwig
2005-02-27T22:23:20Z

On Sun, Feb 27, 2005 at 04:48:10PM +0100, Adrian Bunk wrote:
> - aren't the "if defined(__x86_64__)" wrong for other 64bit
> architectures?

Yes. Having arch or 64bit ifdefs is pretty wrong pretty much always.
In one case it's only used to make a typedef a 32bit or 64bit integeger,
that should be using unsigned long directly always, but the other uses
looks like real problems.