* [PATCH] Replaces (2 * HZ) with DATA_TIMEOUT in /drivers/usb/atm/speedtch.c
@ 2005-02-23 18:42 Telemaque Ndizihiwe
2005-02-23 18:47 ` Linus Torvalds
2005-02-23 23:32 ` Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: Telemaque Ndizihiwe @ 2005-02-23 18:42 UTC (permalink / raw)
To: duncan.sands; +Cc: linux-usb-devel, torvalds, akpm, trivial, linux-kernel, greg
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
This Patch replaces "(2 * HZ)" with "DATA_TIMEOUT" which is defined as
#define DATA_TIMEOUT (2 * HZ)
in /drivers/usb/atm/speedtch.c in kernel 2.6.10.
Signed-off-by: Telemaque Ndizihiwe <telendiz@eircom.net>
--- linux-2.6.10/drivers/usb/atm/speedtch.c.orig 2005-02-20
12:44:22.235267848 +0000
+++ linux-2.6.10/drivers/usb/atm/speedtch.c 2005-02-20
12:50:52.205983288 +0000
@@ -494,7 +494,7 @@ static void speedtch_upload_firmware(str
/* URB 7 */
if (dl_512_first) { /* some modems need a read before writing
the firmware */
ret = usb_bulk_msg(usb_dev, usb_rcvbulkpipe(usb_dev,
SPEEDTCH_ENDPOINT_FIRMWARE),
- buffer, 0x200, &actual_length, 2 * HZ);
+ buffer, 0x200, &actual_length, DATA_TIMEOUT);
if (ret < 0 && ret != -ETIMEDOUT)
dbg("speedtch_upload_firmware: read BLOCK0 from modem
failed (%d)!", ret);
[-- Attachment #2: patch-usb-speedtch --]
[-- Type: text/plain, Size: 625 bytes --]
--- linux-2.6.10/drivers/usb/atm/speedtch.c.orig 2005-02-20 12:44:22.235267848 +0000
+++ linux-2.6.10/drivers/usb/atm/speedtch.c 2005-02-20 12:50:52.205983288 +0000
@@ -494,7 +494,7 @@ static void speedtch_upload_firmware(str
/* URB 7 */
if (dl_512_first) { /* some modems need a read before writing the firmware */
ret = usb_bulk_msg(usb_dev, usb_rcvbulkpipe(usb_dev, SPEEDTCH_ENDPOINT_FIRMWARE),
- buffer, 0x200, &actual_length, 2 * HZ);
+ buffer, 0x200, &actual_length, DATA_TIMEOUT);
if (ret < 0 && ret != -ETIMEDOUT)
dbg("speedtch_upload_firmware: read BLOCK0 from modem failed (%d)!", ret);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Replaces (2 * HZ) with DATA_TIMEOUT in /drivers/usb/atm/speedtch.c
2005-02-23 18:42 [PATCH] Replaces (2 * HZ) with DATA_TIMEOUT in /drivers/usb/atm/speedtch.c Telemaque Ndizihiwe
@ 2005-02-23 18:47 ` Linus Torvalds
2005-02-23 23:32 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Linus Torvalds @ 2005-02-23 18:47 UTC (permalink / raw)
To: Telemaque Ndizihiwe
Cc: duncan.sands, linux-usb-devel, Andrew Morton, trivial,
Kernel Mailing List, Greg KH
On Wed, 23 Feb 2005, Telemaque Ndizihiwe wrote:
>
> This Patch replaces "(2 * HZ)" with "DATA_TIMEOUT" which is defined as
> #define DATA_TIMEOUT (2 * HZ)
> in /drivers/usb/atm/speedtch.c in kernel 2.6.10.
Your patches are white-space damaged due to linewrap (and possibly other
issues, but the line-wrap was the obvious one).
Looks like you use Thunderbird, and I'm sure there's some way to just tell
it to not mess with whitespace.
Linus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Replaces (2 * HZ) with DATA_TIMEOUT in /drivers/usb/atm/speedtch.c
2005-02-23 18:42 [PATCH] Replaces (2 * HZ) with DATA_TIMEOUT in /drivers/usb/atm/speedtch.c Telemaque Ndizihiwe
2005-02-23 18:47 ` Linus Torvalds
@ 2005-02-23 23:32 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2005-02-23 23:32 UTC (permalink / raw)
To: Telemaque Ndizihiwe
Cc: duncan.sands, linux-usb-devel, torvalds, akpm, trivial,
linux-kernel
On Wed, Feb 23, 2005 at 06:42:32PM +0000, Telemaque Ndizihiwe wrote:
> This Patch replaces "(2 * HZ)" with "DATA_TIMEOUT" which is defined as
> #define DATA_TIMEOUT (2 * HZ)
> in /drivers/usb/atm/speedtch.c in kernel 2.6.10.
>
> Signed-off-by: Telemaque Ndizihiwe <telendiz@eircom.net>
This has already been fixed in my tree, due to the change in time value
for the usb_bulk_msg() call. See the latest -mm release to validate
this.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Replaces (2 * HZ) with DATA_TIMEOUT in /drivers/usb/atm/speedtch.c
@ 2005-02-20 13:41 Telemaque Ndizihiwe
0 siblings, 0 replies; 4+ messages in thread
From: Telemaque Ndizihiwe @ 2005-02-20 13:41 UTC (permalink / raw)
To: duncan.sands; +Cc: linux-usb-devel, torvalds, akpm, trivial, linux-kernel
This Patch replaces "(2 * HZ)" with "DATA_TIMEOUT" which is defined as
#define DATA_TIMEOUT (2 * HZ)
in /drivers/usb/atm/speedtch.c in kernel 2.6.10.
Signed-off-by: Telemaque Ndizihiwe <telendiz@eircom.net>
--- linux-2.6.10/drivers/usb/atm/speedtch.c.orig 2005-02-20
12:44:22.235267848 +0000
+++ linux-2.6.10/drivers/usb/atm/speedtch.c 2005-02-20
12:50:52.205983288 +0000
@@ -494,7 +494,7 @@ static void speedtch_upload_firmware(str
/* URB 7 */
if (dl_512_first) { /* some modems need a read before writing the
firmware */
ret = usb_bulk_msg(usb_dev, usb_rcvbulkpipe(usb_dev,
SPEEDTCH_ENDPOINT_FIRMWARE),
- buffer, 0x200, &actual_length, 2 * HZ);
+ buffer, 0x200, &actual_length, DATA_TIMEOUT);
if (ret < 0 && ret != -ETIMEDOUT)
dbg("speedtch_upload_firmware: read BLOCK0 from modem failed (%d)!",
ret);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-02-24 0:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-23 18:42 [PATCH] Replaces (2 * HZ) with DATA_TIMEOUT in /drivers/usb/atm/speedtch.c Telemaque Ndizihiwe
2005-02-23 18:47 ` Linus Torvalds
2005-02-23 23:32 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2005-02-20 13:41 Telemaque Ndizihiwe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox