Re: 2.6.11-rc4-mm1 (VFS: Cannot open root device "301")

Matt Mackall
2005-02-24T00:43:25Z

On Wed, Feb 23, 2005 at 04:16:53PM -0800, Andrew Morton wrote:
> Steven Cole <elenstev@mesatop.com> wrote:
> >
> > > Yes, that worked. 2.6.11-rc4-mm1 now boots OK, but hdb1 seems to be
> > > missing.
>
> Looking at the IDE update in rc4-mm1:
>
> +void ide_init_disk(struct gendisk *disk, ide_drive_t *drive)
> +{
> + ide_hwif_t *hwif = drive->hwif;
> + unsigned int unit = drive->select.all & (1 << 4);
> +
> + disk->major = hwif->major;
> + disk->first_minor = unit << PARTN_BITS;
> + sprintf(disk->disk_name, "hd%c", 'a' + hwif->index * MAX_DRIVES + unit);
> + disk->queue = drive->queue;
> +}
>
> Looks funny.
>
> Could someone try this?
>
> - unsigned int unit = drive->select.all & (1 << 4);
> + unsigned int unit = (drive->select.all >> 4) & 1;

Apparently there's already an 'hdb' sitting in drive->name, perhaps we
ought to do disk->disk_name = drive->name for the non-devfs case.

--
Mathematics is the supreme nostalgia of our time.