Re: 2.6.11-rc4-mm1 (VFS: Cannot open root device "301")

Andrew Morton
2005-02-24T00:15:54Z

Steven Cole <elenstev@mesatop.com> wrote:
>
> > Yes, that worked. 2.6.11-rc4-mm1 now boots OK, but hdb1 seems to be
> > missing.

Looking at the IDE update in rc4-mm1:

+void ide_init_disk(struct gendisk *disk, ide_drive_t *drive)
+{
+ ide_hwif_t *hwif = drive->hwif;
+ unsigned int unit = drive->select.all & (1 << 4);
+
+ disk->major = hwif->major;
+ disk->first_minor = unit << PARTN_BITS;
+ sprintf(disk->disk_name, "hd%c", 'a' + hwif->index * MAX_DRIVES + unit);
+ disk->queue = drive->queue;
+}

Looks funny.

Could someone try this?

- unsigned int unit = drive->select.all & (1 << 4);
+ unsigned int unit = (drive->select.all >> 4) & 1;