Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

Jeff Garzik
2005-03-02T21:07:50Z

Andrew Morton wrote:
> Jeff Garzik <jgarzik@pobox.com> wrote:
>
>>Adrian Bunk wrote:
>>
>>>On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote:
>>>
>>>
>>>>Adrian Bunk wrote:
>>>>
>>>>
>>>>>+ select CRYPTO
>>>>> select CRYPTO_AES
>>>>> ---help---
>>>>> Include software based cipher suites in support of IEEE 802.11i
>>>>> (aka TGi, WPA, WPA2, WPA-PSK, etc.) for use with CCMP enabled
>>>>> networks.
>>>>>@@ -54,10 +55,11 @@
>>>>> "ieee80211_crypt_ccmp".
>>>>>
>>>>>config IEEE80211_CRYPT_TKIP
>>>>> tristate "IEEE 802.11i TKIP encryption"
>>>>> depends on IEEE80211
>>>>>+ select CRYPTO
>>>>> select CRYPTO_MICHAEL_MIC
>>>>
>>>>
>>>>'select CRYPTO_AES' should 'select CRYPTO' automatically, I would hope.
>>>
>>>
>>>This would result in a recursive dependency.
>>
>>No, it wouldn't. CRYPTO_AES depends on CRYPTO, which depends on nothing.
>>
>
>
> Thing is, CRYPTO_AES on only selectable on x86.

You're thinking about CRYPTO_AES_586. But looking at crypto/Kconfig,
the dependencies are a bit weird:

config CRYPTO_AES
tristate "AES cipher algorithms"
depends on CRYPTO && !(X86 && !X86_64)
config CRYPTO_AES_586
tristate "AES cipher algorithms (i586)"
depends on CRYPTO && (X86 && !X86_64)