From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EF321E98EF for ; Sun, 16 Nov 2025 17:22:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763313756; cv=none; b=SAi6QkvIvh9aYPWmVRjJ9ZPqxnq0KQNaiWhQd2/oEzXP+BpRNEnYd08YHo3lqlgEJtV9lyDd6w4hf39mXZSmpHMw0K+Etx9i0dsXPa5L0piSiJfZn/cdPt+9P/dTKUXRSqQWvrjGhg2UgeUZ7cifcyjted3n13CO7Eu17SXFivg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763313756; c=relaxed/simple; bh=ZQoa4/71BzJBFDoQZEsiK4LF7Qve7xBGlX1DGk5TiBs=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=EjUV4RaSr/Iv7uRz10PiETee4L89ouwm+1RmshgTLh8J4Twao6qixUrlk7w3d5F7HT2A4R9la3mi0ql+CkcA7fjUP5/z/pkSx7BrGf3v/b0tad3trCTqz5bM9u4BVctbmGah1D/ZNUCoiKCZ3mKMFvG1eWOj+pO40LvOj2JHyIw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qXiGnZWB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qXiGnZWB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40621C4CEFB; Sun, 16 Nov 2025 17:22:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763313756; bh=ZQoa4/71BzJBFDoQZEsiK4LF7Qve7xBGlX1DGk5TiBs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=qXiGnZWB9Ng67BQLoGrzVSSzQ7NrNm3MJCNMAfjJYp+y5YL1eP44XvKuYuzohpOxC 2g4iRL4qtGAs1AJ3n1h1xVPjmTpgbyx0+WwsIz2jSdNgQ+6tpMtzwWz2kXCtCOIoku 8AZlPVItKR2xibjBpuQp7z6/Ijdf1mhGZibWhdWRt5/DgVt/fCfxXqPO0yD+hlm0Z5 zJ0xlR76NvpnomZJiNNGZEkEkoCXlktzXuh15tvkt02I1fYbUgWO1olNqpIb5vXrpr kselxtDIf9H6flvjXiGUNFY3v7uYDKfZ4vu/Z1GuzfGMgHXkATwlrYahaRF5ee9uBH FCFcs0+l45yfQ== Date: Sun, 16 Nov 2025 10:22:34 -0700 (MST) From: Paul Walmsley To: Chen Pei cc: anup@brainfault.org, atish.patra@linux.dev, pjw@kernel.org, haibo1.xu@intel.com, guoren@kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools: riscv: Fixed misalignment of CSR related definitions In-Reply-To: <20251114071215.816-1-cp0613@linux.alibaba.com> Message-ID: <421f4746-8d75-227b-6459-bbd82dfd6fa9@kernel.org> References: <20251114071215.816-1-cp0613@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi, On Fri, 14 Nov 2025, cp0613@linux.alibaba.com wrote: > From: Chen Pei > > The file tools/arch/riscv/include/asm/csr.h borrows from > arch/riscv/include/asm/csr.h, and subsequent modifications > related to CSR should maintain consistency. Thanks for the patch. A few comments: > Fixes: 16b0bde9a37c ("RISC-V: KVM: Add perf sampling support for guests") > Fixes: d1927f64e0e1 ("RISC-V: Fix the typo in Scountovf CSR name") It seems like this is pushing the definition of "fixes" here. It looks like the only thing wrong with those patches is that they didn't change the files under tools/. right? It would have been nice if they had included the changes to files under tools/, but since the patches don't introduce any bugs directly, I don't think we should include these Fixes: lines here. > > Signed-off-by: Chen Pei Please, no blank line between the Fixes: headers and the Signed-off-by:. I've removed the Fixes: lines and the superfluous blank line, and queued this for v6.18-rc fixes. - Paul