From: Jeff Garzik <jgarzik@pobox.com>
To: Wen Xiong <wendyx@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Andrew Morton <akpm@osdl.org>
Subject: Re: [ patch 2/7] drivers/serial/jsm: new serial device driver
Date: Sun, 27 Feb 2005 19:25:11 -0500 [thread overview]
Message-ID: <422264E7.1030602@pobox.com> (raw)
In-Reply-To: <42225A04.7080505@us.ltcfwd.linux.ibm.com>
Wen Xiong wrote:
> +#define TMPBUFLEN (1024)
> +
> +/*
> + * jsm_sniff - Dump data out to the "sniff" buffer if the
> + * proc sniff file is opened...
> + */
> +
> +void jsm_sniff_nowait_nolock(struct channel_t *ch, uchar *text, uchar *buf, int len)
> +{
> + struct timeval tv;
> + int n;
> + int r;
> + int nbuf;
> + int i;
> + int tmpbuflen;
> + char tmpbuf[TMPBUFLEN];
Uses WAY too much stack space.
Jeff
next prev parent reply other threads:[~2005-02-28 0:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-27 23:38 [ patch 2/7] drivers/serial/jsm: new serial device driver Wen Xiong
2005-02-28 0:25 ` Jeff Garzik [this message]
2005-02-28 6:37 ` Greg KH
2005-03-04 21:07 ` Wen Xiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=422264E7.1030602@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=wendyx@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox