Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

[Jay Lan <jlan@sgi.com>]

Sorry I was not clear on my point.

I was trying to point out that, an exit hook for BSD and CSA is
essential to save accounting data before the data is gone. That
can not be done with a netlink.

So, my patch was to keep acct_process as a wrapper, which
would then call do_exit_csa() for CSA and call do_acct_process
for BSD.

Thanks,
  - jay


Guillaume Thouvenin wrote:
> On Mon, 2005-02-28 at 10:56 -0800, Jay Lan wrote:
> 
>>The exit hook is essential for CSA to save off data before the data
>>is gone, A netlink type of thing does not help. BSD is in the same
>>situation. You can not replace the acct_process() call with a netlink.
>>If ELSA is to use the enhanced accounting data, it needs the CSA
>>eop handling at exit as well.
> 
> 
> Why replace the acct_process()? The problem here is to add a new hook in
> the do_fork() and you can use the BSD accounting hook acct_process()
> which is already in the exit() routine. We don't need to replace it with
> a netlink because today there are no user space applications that need
> it. 
> 
> Best regards,
> Guillaume