From: Jeff Garzik <jgarzik@pobox.com>
To: panagiotis.issaris@mech.kuleuven.ac.be
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Possible VIA-Rhine free irq issue
Date: Wed, 02 Mar 2005 01:22:41 -0500 [thread overview]
Message-ID: <42255BB1.5000301@pobox.com> (raw)
In-Reply-To: <20050228145032.B32550@lumumba.luc.ac.be>
Panagiotis Issaris wrote:
> Hi,
>
> It seems to me that in the VIA Rhine device driver the requested irq might
> not be freed in case the alloc_ring() function fails. alloc_ring()
> can fail with a ENOMEM return value because of possible
> pci_alloc_consistent() failures.
>
> This patch applies to 2.6.11-rc5-bk2.
>
> diff -uprN linux-2.6.11-rc5-bk2/drivers/net/via-rhine.c linux-2.6.11-rc5-bk2-pi/drivers/net/via-rhine.c
> --- linux-2.6.11-rc5-bk2/drivers/net/via-rhine.c 2005-02-28 13:44:37.000000000 +0100
> +++ linux-2.6.11-rc5-bk2-pi/drivers/net/via-rhine.c 2005-02-28 13:44:31.000000000 +0100
> @@ -1198,7 +1198,10 @@ static int rhine_open(struct net_device
>
> rc = alloc_ring(dev);
> if (rc)
> + {
> + free_irq(rp->pdev->irq, dev);
> return rc;
> + }
Yes, this is a needed fix. Thanks,
Jeff
prev parent reply other threads:[~2005-03-02 6:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-28 13:50 [PATCH] Possible VIA-Rhine free irq issue Panagiotis Issaris
2005-03-02 6:22 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42255BB1.5000301@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=panagiotis.issaris@mech.kuleuven.ac.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox