From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1034498AbdAEVnK (ORCPT <rfc822;w@1wt.eu>);
        Thu, 5 Jan 2017 16:43:10 -0500
Received: from mout.kundenserver.de ([217.72.192.75]:53507 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934597AbdAEVnA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 5 Jan 2017 16:43:00 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: "Andrew F. Davis" <afd@ti.com>, Russell King <linux@armlinux.org.uk>,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
        Wolfram Sang <wsa@the-dreams.de>, Richard Purdie <rpurdie@rpsys.net>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
        Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
        Samuel Ortiz <sameo@linux.intel.com>, Ingo Molnar <mingo@kernel.org>,
        linux-pwm@vger.kernel.org, linux-wireless@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v2 6/6] [media] Only descend into directory when CONFIG_MEDIA_SUPPORT is set
Date: Thu, 05 Jan 2017 22:42:16 +0100
Message-ID: <4225650.R96pl5clWf@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <20170105210158.14204-7-afd@ti.com>
References: <20170105210158.14204-1-afd@ti.com> <20170105210158.14204-7-afd@ti.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:AVXYRWnmJDntdaZeWxvwBYh8QJh9msT29cEtBPSDOGkTdp9RuJC
 bKmPFI12yYAM0RZ6FSs8E/VeOBriSh7ZTXHynX+XDXN/JuBumdN7Kv2RlGMZ4Ih+yM2hf8x
 0X9Ns9fFUg3anmtuJH2TgHNImG8FmWE5QXNXa0bIaNDPfORDN/dyls7q2mWmN+5L2EJyL2I
 Y1HLX7KL7aenKA6rRKjvA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:x5S5aSaD7Ic=:jk0851qu1gAO2PxlEWOoXO
 i+5/n8qia8dLXn1+SGfAEwOaKP8sXsfiQ94J2c0MTH11iMJWFn3BX8W/+lJap4D7xwKSTXJqA
 9wcywVcFNHnnImh5O9IotnmZWoMCwrY9GNKlTIjXh1mVq3tfD2UodpDHhw2pUW6oJeO6lc1uu
 usil7yzR3bgg7pLhA9ofgEuqGQiZg6UciWQHwywSN8xKxrjL6LqY7pRg4hW62F6UIAOiwDNb2
 f4LDhzsZWC3+vPF0vXta5lyJAlcqV9Skdo4TM0/61Ee4341XyGi+wQ3DCmTW807+iqqFBNPeO
 Y7DVXW/ANwUlKd75p2Xlkszpwx5QXdeh9JIHFfNrT2atBf548s4Eops8al2zrcoM3k7P9rzZd
 JIYH7S1GD9lW/HmujhqihOVu2f2GLdINvP9XBX81dROw0ajNe6JiW28ja3Mjp9utWNrCT5sQP
 h/9sENEcSik/g4W5pOPDxwGF1R795OAAbyZQExBx4h0rhd2CTa0If8aMssvXqZ+Aofa/gRLBk
 QvGg3xUkhRowjhYMasZ360H66doIn+InqW9JHkzdDC7eikvBD8/o+0Eha2Q0lv/UnS7/U/QNr
 YSgV9m9yAeAfAHdxNNdm7icfiWBakbU1ZWio0tbLUvr/lvqyioSd/D2VvG1fr1sTuzHjNHx0Z
 W0LouHSpyd8az7bAh5LmK3Cq/MkXzSP8Sx3d4OwSvtoU0quWgoIy8VVvBfOATGivFzd8G9yuH
 oeWyg1o/RCTxRDoD
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday, January 5, 2017 3:01:58 PM CET Andrew F. Davis wrote:
> @@ -109,7 +109,8 @@ obj-$(CONFIG_SERIO)         += input/serio/
>  obj-$(CONFIG_GAMEPORT)         += input/gameport/
>  obj-$(CONFIG_INPUT)            += input/
>  obj-$(CONFIG_RTC_LIB)          += rtc/
> -obj-y                          += i2c/ media/
> +obj-y                          += i2c/
> +obj-$(CONFIG_MEDIA_SUPPORT)    += media/
>  obj-$(CONFIG_PPS)              += pps/
>  obj-y                          += ptp/
>  obj-$(CONFIG_W1)               += w1/
> 

This one seems wrong: if CONFIG_MEDIA_SUPPORT=m, but some I2C drivers
inside of drivers/media/ are built-in, we will fail to enter the directory,
see drivers/media/Makefile.

I checked the other five patches in the series as well, they all look
ok to me.

	Arnd