Re: [PATCH/RFC] I/O-check interface for driver's error handling

Benjamin Herrenschmidt
2005-03-02T22:50:34Z

On Wed, 2005-03-02 at 14:02 -0600, Linas Vepstas wrote:
> On Wed, Mar 02, 2005 at 09:27:27AM +1100, Benjamin Herrenschmidt was heard to remark:

> That's a style issue. Propose an API, I'll code it. We can have
> the master recovery thread be a state machine, and so every device
> driver gets notified of state changes:
>
> typedef enum pci_bus_state {
> DEVICE_IO_FROZEN=1,
> DEVICE_IO_THAWED,
> DEVICE_PERM_FAILURE,
> };
>
> struct pci_driver {
> ....
> void (*io_state_change) (struct pci_dev *dev, pci_bus_state);
> };
>
> would that work?

Too much ppc64-centric.

Also, we want to use the re-enable IOs facility of EEH to give the
driver a chance to extract diagnostic infos from the HW.

Ben.