Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

[Jeff Mahoney <jeffm@suse.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Olaf Hering wrote:
>  On Thu, Mar 03, Jeff Mahoney wrote:
> 
> 
>>-----BEGIN PGP SIGNED MESSAGE-----
>>Hash: SHA1
>>
>>Olaf Hering wrote:
>>
>>> On Thu, Mar 03, Jeff Mahoney wrote:
>>>
>>>
>>>
>>>>Is whitespace (in any form) allowed in the compatible value?
>>>
>>>
>>>Yes, whitespace is used at least in the toplevel compatible file, like
>>>'Power Macintosh' in some Pismo models.
>>>
>>
>>Oh well, it was wishful thinking anyway. ;)
> 
> 
> The same thing needs to be solved for vio devices, the properties can
> contain spaces. depmod and modprobe have to deal with it to generate a
> valid module.alias file.

The solution I ended up going with was the original CRLF suggestion, and
then I pass around a group of environment vars in userspace rather than
a single line. This works as before, but works with commas and isn't as
ugly as I had thought it might be.

As far as the modules.aliases file goes, I'm not sure what our options
are there. Is the only requirement that the aliases be consistent in the
kernel and in userspace? Since aliases for OF devices haven't previously
existed, I defined the format. Is there any reason I couldn't define the
format such that whitepsace is replaced by underscores, thus eliminating
this issue?

- -Jeff

- --
Jeff Mahoney
SuSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFCKI4+LPWxlyuTD7IRAvNOAJ0aopD1JcpUpoAMeuI1EVSBVbICCQCgmHVN
QKswIpQ//5SxjnXIk02PBts=
=K/kB
-----END PGP SIGNATURE-----