From: Ondrej Zary <linux@rainbow-software.org>
To: domen@coderock.org
Cc: emoenke@gwdg.de, linux-kernel@vger.kernel.org, nacc@us.ibm.com
Subject: Re: [patch 2/6] 12/34: cdrom/cdu31a: replace interruptible_sleep_on() with wait_event_interruptible()
Date: Sun, 06 Mar 2005 12:42:55 +0100 [thread overview]
Message-ID: <422AECBF.7040507@rainbow-software.org> (raw)
In-Reply-To: <20050306103155.4AC7D1F202@trashy.coderock.org>
domen@coderock.org wrote:
> Use wait_event_interruptible() instead of the deprecated
> interruptible_sleep_on(). The patch is straight-forward as the macros should
> result in the same execution. Patch is compile-tested (still throws out warnings
> regarding {save,restore}_flags()).
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> Signed-off-by: Domen Puncer <domen@coderock.org>
I've posted a patch for the cdu31a driver some time ago that removes
almost all usage of interruptible_sleep_on() and also
{save,restore}_flags() - it uses semaphore instead.
The only remaining code is in sony_sleep() function when using
IRQ-driven operation.
See http://lkml.org/lkml/2004/12/18/107
The patch is big because I've messed with the formatting...
--
Ondrej Zary
next prev parent reply other threads:[~2005-03-06 11:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-06 10:31 [patch 2/6] 12/34: cdrom/cdu31a: replace interruptible_sleep_on() with wait_event_interruptible() domen
2005-03-06 11:42 ` Ondrej Zary [this message]
2005-03-06 21:04 ` Domen Puncer
2005-03-06 22:17 ` Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=422AECBF.7040507@rainbow-software.org \
--to=linux@rainbow-software.org \
--cc=domen@coderock.org \
--cc=emoenke@gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox