public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jay Lan <jlan@sgi.com>
To: Guillaume Thouvenin <guillaume.thouvenin@bull.net>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Tim Schmielau <tim@physik3.uni-rostock.de>,
	Jay Lan <jlan@engr.sgi.com>
Subject: Re: I/O and Memory accounting...
Date: Wed, 09 Mar 2005 10:26:32 -0800	[thread overview]
Message-ID: <422F3FD8.5020204@sgi.com> (raw)
In-Reply-To: <1110374723.10590.116.camel@frecb000711.frec.bull.fr>

I thought you planned to read from CSA pacct file?

Well, while we are in discussion of whether to merge and
replace BSD accounting with CSA accounting, your proposed
change will provide you data on charater I/O in a BSD pacct
file. I supposed you do not need to have seperate fields on
character-read and character-written? CSA will provide the
data separately.

CSA writes the data to a CSA pacct file in a similar way as
BSD on exit callback at do_acct_process(). The CSA's exit
callback is implemented as a loadable module. The CSA
project and code can be downloaded at
http://oss.sgi.com/projects/csa.

Cheers,
  - jay


Guillaume Thouvenin wrote:
> Hello,
> 
>   In the ChangeLog-2.6.11 file I read that the enhanced I/O accounting
> data patch and the enhanced memory accounting data collection patch were
> added. It's cool but I don't see how this stuff is used because
> information is never dump in a file or send to an accounting application
> (or I miss something). 
>  
>   Maybe we should update the ac_io in the "struct acct"? Thus, values
> will be dump in the accounting file. Maybe it could be something like:
> 
> --- acct.c.orig	2005-03-09 14:17:07.000000000 +0100
> +++ acct.c	2005-03-09 14:18:20.000000000 +0100
> @@ -477,8 +477,8 @@ static void do_acct_process(long exitcod
>  	}
>  	vsize = vsize / 1024;
>  	ac.ac_mem = encode_comp_t(vsize);
> -	ac.ac_io = encode_comp_t(0 /* current->io_usage */);	/* %% */
> -	ac.ac_rw = encode_comp_t(ac.ac_io / 1024);
> +	ac.ac_io = encode_comp_t(current->rchar + current->wchar);
> +	ac.ac_rw = encode_comp_t(0);
>  	ac.ac_minflt = encode_comp_t(current->signal->min_flt +
>  				     current->group_leader->min_flt);
>  	ac.ac_majflt = encode_comp_t(current->signal->maj_flt +
> 
> 
> For memory and read/write syscall we may add new fields. 
> 
> Best regards,
> Guillaume
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


      reply	other threads:[~2005-03-09 18:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-09 13:25 I/O and Memory accounting Guillaume Thouvenin
2005-03-09 18:26 ` Jay Lan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=422F3FD8.5020204@sgi.com \
    --to=jlan@sgi.com \
    --cc=guillaume.thouvenin@bull.net \
    --cc=jlan@engr.sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tim@physik3.uni-rostock.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox