Re: Aw: [PATCH] arm64: dts: rockchip: Fix clocks for rk356x usb

Heiko Stuebner
2022-04-09T10:23:52Z

Am Samstag, 9. April 2022, 12:14:28 CEST schrieb Frank Wunderlich:
> Hi,
>
> > Gesendet: Samstag, 09. April 2022 um 09:51 Uhr
> > Von: "Frank Wunderlich" <linux@fw-web.de>
>
> > - clock-names = "ref_clk", "suspend_clk",
> > - "bus_clk";
> > + clock-names = "ref", "suspend_clk",
> > + "bus_early";
> > dr_mode = "host";
> > phy_type = "utmi_wide";
> > power-domains = <&power RK3568_PD_PIPE>;
> > @@ -280,8 +280,8 @@ usb_host1_xhci: usb@fd000000 {
> > interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&cru CLK_USB3OTG1_REF>, <&cru CLK_USB3OTG1_SUSPEND>,
> > <&cru ACLK_USB3OTG1>;
> > - clock-names = "ref_clk", "suspend_clk",
> > - "bus_clk";
> > + clock-names = "ref", "suspend_clk",
> > + "bus_early";
> > dr_mode = "host";
>
> this is the patch breaking it:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=33fb697ec7e58c4f9b6a68d2786441189cd2df92
>
> suspend clock needs to be renamed too from "suspend_clk" to "suspend"
>
> else i get this error on poweroff
>
> xhci-hcd xhci-hcd.1.auto: Host halt failed, -110
>
> regards Frank

ok, so do you want to send a v2 including that change?
Alternatively I can also add this change when applying.

Also for educational purposes, the format for referencing a commit
you're fixing would be

Fixes: 33fb697ec7e5 ("usb: dwc3: Get clocks individually")
Signed-off-by: ....

Heiko