RE: [PATCH 1/6] PCI Express Advanced Error Reporting Driver

Nguyen, Tom L
2005-03-16T00:05:47Z

Tuesday, March 15, 2005 2:51 PM Linas Vepstas wrote:
>> +void hw_aer_unregister(void)
>> +{
>> + struct pci_dev *dev = (struct pci_dev*)host->dev;
>> + unsigned short id;
>> +
>> + id = (dev->bus->number << 8) | dev->devfn;
>> +
>> + /* Unregister with AER Root driver */
>> + pcie_aer_unregister(id);
>> +}
>
>I don't understand how this can work on a system with
>more than one domain. On any midrange/high-end system,
>you'll have a number of devices with identical values
>for (bus->number << 8) | devfn)

Good catch! I forgot to encounter multiple segments. However, based on
LKML inputs for a common interface in the pci_driver data structure, it
appears that pcie_aer_register and pcie_aer_unregister are no longer
required.

Thanks,
Long