From: Like Xu <like.xu.linux@gmail.com>
To: "Paolo Bonzini - Distinguished Engineer (kernel-recipes.org)
(KVM HoF)" <pbonzini@redhat.com>,
Xinghui Li <korantli@tencent.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
kvm@vger.kernel.org, korantwork@gmail.com, seanjc@google.com,
tglx@linutronix.de, mingo@redhat.com, mlevitsk@redhat.com
Subject: Re: [PATCH REBASED] KVM: x86: SVM: Fix one redefine issue about VMCB_AVIC_APIC_BAR_MASK
Date: Tue, 4 Apr 2023 16:40:01 +0800 [thread overview]
Message-ID: <4235f3f7-bae5-1f5e-582e-077bc5d03306@gmail.com> (raw)
In-Reply-To: <20230403095200.1391782-1-korantwork@gmail.com>
On 3/4/2023 5:52 pm, korantwork@gmail.com wrote:
> From: Xinghui Li <korantli@tencent.com>
>
> VMCB_AVIC_APIC_BAR_MASK is defined twice with the same value in svm.h,
> which is meaningless. Delete the duplicate one.
>
> Fixes: 391503528257 ("KVM: x86: SVM: move avic definitions from AMD's spec to svm.h")
> Signed-off-by: Xinghui Li <korantli@tencent.com>
Reviewed-by: Like Xu <likexu@tencent.com>
Do we have any tool to find out more similar issues across numerous subsystems ?
> ---
> arch/x86/include/asm/svm.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/svm.h b/arch/x86/include/asm/svm.h
> index 770dcf75eaa9..e236b896f8b4 100644
> --- a/arch/x86/include/asm/svm.h
> +++ b/arch/x86/include/asm/svm.h
> @@ -278,7 +278,6 @@ static_assert((AVIC_MAX_PHYSICAL_ID & AVIC_PHYSICAL_MAX_INDEX_MASK) == AVIC_MAX_
> static_assert((X2AVIC_MAX_PHYSICAL_ID & AVIC_PHYSICAL_MAX_INDEX_MASK) == X2AVIC_MAX_PHYSICAL_ID);
>
> #define AVIC_HPA_MASK ~((0xFFFULL << 52) | 0xFFF)
> -#define VMCB_AVIC_APIC_BAR_MASK 0xFFFFFFFFFF000ULL
>
>
> struct vmcb_seg {
next prev parent reply other threads:[~2023-04-04 8:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 9:52 [PATCH REBASED] KVM: x86: SVM: Fix one redefine issue about VMCB_AVIC_APIC_BAR_MASK korantwork
2023-04-04 8:40 ` Like Xu [this message]
2023-04-04 10:38 ` Xinghui Li
2023-04-04 23:43 ` Sean Christopherson
2023-04-06 2:21 ` Xinghui Li
2023-04-06 2:31 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4235f3f7-bae5-1f5e-582e-077bc5d03306@gmail.com \
--to=like.xu.linux@gmail.com \
--cc=korantli@tencent.com \
--cc=korantwork@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox