* [PATCH] buildcheck: reduce DEBUG_INFO noise from reference* scripts
@ 2005-03-14 19:02 Randy.Dunlap
2005-03-14 19:38 ` Sam Ravnborg
2005-03-14 20:33 ` Keith Owens
0 siblings, 2 replies; 6+ messages in thread
From: Randy.Dunlap @ 2005-03-14 19:02 UTC (permalink / raw)
To: lkml; +Cc: kaos, akpm
Reduce noise in 'make buildcheck' that is caused by CONFIG_DEBUG_INFO=y.
Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
diffstat:=
scripts/reference_discarded.pl | 3 +++
scripts/reference_init.pl | 1 +
2 files changed, 4 insertions(+)
diff -Naurp ./scripts/reference_discarded.pl~ref_init_debugs ./scripts/reference_discarded.pl
--- ./scripts/reference_discarded.pl~ref_init_debugs 2005-03-01 23:38:08.000000000 -0800
+++ ./scripts/reference_discarded.pl 2005-03-14 10:38:47.000000000 -0800
@@ -82,6 +82,8 @@ foreach $object (keys(%object)) {
}
if (($line =~ /\.text\.exit$/ ||
$line =~ /\.exit\.text$/ ||
+ $line =~ /\.text\.init$/ ||
+ $line =~ /\.init\.text$/ ||
$line =~ /\.data\.exit$/ ||
$line =~ /\.exit\.data$/ ||
$line =~ /\.exitcall\.exit$/) &&
@@ -96,6 +98,7 @@ foreach $object (keys(%object)) {
$from !~ /\.debug_ranges$/ &&
$from !~ /\.debug_line$/ &&
$from !~ /\.debug_frame$/ &&
+ $from !~ /\.debug_loc$/ &&
$from !~ /\.exitcall\.exit$/ &&
$from !~ /\.eh_frame$/ &&
$from !~ /\.stab$/)) {
diff -Naurp ./scripts/reference_init.pl~ref_init_debugs ./scripts/reference_init.pl
--- ./scripts/reference_init.pl~ref_init_debugs 2005-03-01 23:38:17.000000000 -0800
+++ ./scripts/reference_init.pl 2005-03-14 10:40:19.000000000 -0800
@@ -98,6 +98,7 @@ foreach $object (sort(keys(%object))) {
$from !~ /\.pdr$/ &&
$from !~ /\__param$/ &&
$from !~ /\.altinstructions/ &&
+ $from !~ /\.eh_frame/ &&
$from !~ /\.debug_/)) {
printf("Error: %s %s refers to %s\n", $object, $from, $line);
}
---
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] buildcheck: reduce DEBUG_INFO noise from reference* scripts
2005-03-14 19:02 [PATCH] buildcheck: reduce DEBUG_INFO noise from reference* scripts Randy.Dunlap
@ 2005-03-14 19:38 ` Sam Ravnborg
2005-03-14 20:33 ` Keith Owens
1 sibling, 0 replies; 6+ messages in thread
From: Sam Ravnborg @ 2005-03-14 19:38 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: lkml, kaos, akpm
On Mon, Mar 14, 2005 at 11:02:09AM -0800, Randy.Dunlap wrote:
>
> Reduce noise in 'make buildcheck' that is caused by CONFIG_DEBUG_INFO=y.
Applied to my kbuild tree.
Sam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] buildcheck: reduce DEBUG_INFO noise from reference* scripts
2005-03-14 19:02 [PATCH] buildcheck: reduce DEBUG_INFO noise from reference* scripts Randy.Dunlap
2005-03-14 19:38 ` Sam Ravnborg
@ 2005-03-14 20:33 ` Keith Owens
2005-03-14 21:38 ` Randy.Dunlap
1 sibling, 1 reply; 6+ messages in thread
From: Keith Owens @ 2005-03-14 20:33 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: lkml, akpm
On Mon, 14 Mar 2005 11:02:09 -0800,
"Randy.Dunlap" <rddunlap@osdl.org> wrote:
>
>Reduce noise in 'make buildcheck' that is caused by CONFIG_DEBUG_INFO=y.
>
>Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
>
>diffstat:=
> scripts/reference_discarded.pl | 3 +++
> scripts/reference_init.pl | 1 +
> 2 files changed, 4 insertions(+)
>
>diff -Naurp ./scripts/reference_discarded.pl~ref_init_debugs ./scripts/reference_discarded.pl
>--- ./scripts/reference_discarded.pl~ref_init_debugs 2005-03-01 23:38:08.000000000 -0800
>+++ ./scripts/reference_discarded.pl 2005-03-14 10:38:47.000000000 -0800
>@@ -82,6 +82,8 @@ foreach $object (keys(%object)) {
> }
> if (($line =~ /\.text\.exit$/ ||
> $line =~ /\.exit\.text$/ ||
>+ $line =~ /\.text\.init$/ ||
>+ $line =~ /\.init\.text$/ ||
> $line =~ /\.data\.exit$/ ||
> $line =~ /\.exit\.data$/ ||
> $line =~ /\.exitcall\.exit$/) &&
>@@ -96,6 +98,7 @@ foreach $object (keys(%object)) {
> $from !~ /\.debug_ranges$/ &&
> $from !~ /\.debug_line$/ &&
> $from !~ /\.debug_frame$/ &&
>+ $from !~ /\.debug_loc$/ &&
> $from !~ /\.exitcall\.exit$/ &&
> $from !~ /\.eh_frame$/ &&
> $from !~ /\.stab$/)) {
>diff -Naurp ./scripts/reference_init.pl~ref_init_debugs ./scripts/reference_init.pl
>--- ./scripts/reference_init.pl~ref_init_debugs 2005-03-01 23:38:17.000000000 -0800
>+++ ./scripts/reference_init.pl 2005-03-14 10:40:19.000000000 -0800
>@@ -98,6 +98,7 @@ foreach $object (sort(keys(%object))) {
> $from !~ /\.pdr$/ &&
> $from !~ /\__param$/ &&
> $from !~ /\.altinstructions/ &&
>+ $from !~ /\.eh_frame/ &&
> $from !~ /\.debug_/)) {
> printf("Error: %s %s refers to %s\n", $object, $from, $line);
> }
>
Adding .debug_loc and .eh_frame to the exclude lists is fine. But why
add .text.init and .init.text to the selection list in
reference_discarded.pl? reference_discarded.pl only looks at exit
sections, not init sections. reference_init.pl already handles the
init sections.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] buildcheck: reduce DEBUG_INFO noise from reference* scripts
2005-03-14 20:33 ` Keith Owens
@ 2005-03-14 21:38 ` Randy.Dunlap
2005-03-14 21:40 ` Sam Ravnborg
0 siblings, 1 reply; 6+ messages in thread
From: Randy.Dunlap @ 2005-03-14 21:38 UTC (permalink / raw)
To: Keith Owens; +Cc: lkml, akpm, sam
Keith Owens wrote:
> On Mon, 14 Mar 2005 11:02:09 -0800,
> "Randy.Dunlap" <rddunlap@osdl.org> wrote:
>
>>Reduce noise in 'make buildcheck' that is caused by CONFIG_DEBUG_INFO=y.
>>
>>Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
>>
>>diffstat:=
>>scripts/reference_discarded.pl | 3 +++
>>scripts/reference_init.pl | 1 +
>>2 files changed, 4 insertions(+)
>>
>>diff -Naurp ./scripts/reference_discarded.pl~ref_init_debugs ./scripts/reference_discarded.pl
>>--- ./scripts/reference_discarded.pl~ref_init_debugs 2005-03-01 23:38:08.000000000 -0800
>>+++ ./scripts/reference_discarded.pl 2005-03-14 10:38:47.000000000 -0800
>>@@ -82,6 +82,8 @@ foreach $object (keys(%object)) {
>> }
>> if (($line =~ /\.text\.exit$/ ||
>> $line =~ /\.exit\.text$/ ||
>>+ $line =~ /\.text\.init$/ ||
>>+ $line =~ /\.init\.text$/ ||
>> $line =~ /\.data\.exit$/ ||
>> $line =~ /\.exit\.data$/ ||
>> $line =~ /\.exitcall\.exit$/) &&
>>@@ -96,6 +98,7 @@ foreach $object (keys(%object)) {
>> $from !~ /\.debug_ranges$/ &&
>> $from !~ /\.debug_line$/ &&
>> $from !~ /\.debug_frame$/ &&
>>+ $from !~ /\.debug_loc$/ &&
>> $from !~ /\.exitcall\.exit$/ &&
>> $from !~ /\.eh_frame$/ &&
>> $from !~ /\.stab$/)) {
>>diff -Naurp ./scripts/reference_init.pl~ref_init_debugs ./scripts/reference_init.pl
>>--- ./scripts/reference_init.pl~ref_init_debugs 2005-03-01 23:38:17.000000000 -0800
>>+++ ./scripts/reference_init.pl 2005-03-14 10:40:19.000000000 -0800
>>@@ -98,6 +98,7 @@ foreach $object (sort(keys(%object))) {
>> $from !~ /\.pdr$/ &&
>> $from !~ /\__param$/ &&
>> $from !~ /\.altinstructions/ &&
>>+ $from !~ /\.eh_frame/ &&
>> $from !~ /\.debug_/)) {
>> printf("Error: %s %s refers to %s\n", $object, $from, $line);
>> }
>>
>
>
> Adding .debug_loc and .eh_frame to the exclude lists is fine. But why
> add .text.init and .init.text to the selection list in
> reference_discarded.pl? reference_discarded.pl only looks at exit
> sections, not init sections. reference_init.pl already handles the
> init sections.
Indeed, it's actually much worse with that patch section added. :(
I don't know how I got there.
Sam, can you drop the very first patch section here, or shall I send
a new patch for this?
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] buildcheck: reduce DEBUG_INFO noise from reference* scripts
2005-03-14 21:38 ` Randy.Dunlap
@ 2005-03-14 21:40 ` Sam Ravnborg
2005-03-14 21:50 ` Randy.Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Sam Ravnborg @ 2005-03-14 21:40 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: Keith Owens, lkml, akpm
On Mon, Mar 14, 2005 at 01:38:11PM -0800, Randy.Dunlap wrote:
Indeed, it's actually much worse with that patch section added. :(
> I don't know how I got there.
>
> Sam, can you drop the very first patch section here, or shall I send
> a new patch for this?
Incremental patch please. I already have a few patches on top of this in
bitkeeper.
Sam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] buildcheck: reduce DEBUG_INFO noise from reference* scripts
2005-03-14 21:40 ` Sam Ravnborg
@ 2005-03-14 21:50 ` Randy.Dunlap
0 siblings, 0 replies; 6+ messages in thread
From: Randy.Dunlap @ 2005-03-14 21:50 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Keith Owens, lkml, akpm
[-- Attachment #1: Type: text/plain, Size: 450 bytes --]
Sam Ravnborg wrote:
> On Mon, Mar 14, 2005 at 01:38:11PM -0800, Randy.Dunlap wrote:
> Indeed, it's actually much worse with that patch section added. :(
>
>>I don't know how I got there.
>>
>>Sam, can you drop the very first patch section here, or shall I send
>>a new patch for this?
>
> Incremental patch please. I already have a few patches on top of this in
> bitkeeper.
>
> Sam
Here you go.... back out those 2 lines.
Thanks,
--
~Randy
[-- Attachment #2: refer_discard_no_init.patch --]
[-- Type: text/x-patch, Size: 822 bytes --]
I should not have added init.text test here;
it's more than useless, it actually degrades the output.
Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
diffstat:=
scripts/reference_discarded.pl | 2 --
1 files changed, 2 deletions(-)
diff -Naurp ./scripts/reference_discarded.pl~refer_discard_no_init ./scripts/reference_discarded.pl
--- ./scripts/reference_discarded.pl~refer_discard_no_init 2005-03-14 13:44:54.000000000 -0800
+++ ./scripts/reference_discarded.pl 2005-03-14 13:46:07.000000000 -0800
@@ -82,8 +82,6 @@ foreach $object (keys(%object)) {
}
if (($line =~ /\.text\.exit$/ ||
$line =~ /\.exit\.text$/ ||
- $line =~ /\.text\.init$/ ||
- $line =~ /\.init\.text$/ ||
$line =~ /\.data\.exit$/ ||
$line =~ /\.exit\.data$/ ||
$line =~ /\.exitcall\.exit$/) &&
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-03-14 21:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-14 19:02 [PATCH] buildcheck: reduce DEBUG_INFO noise from reference* scripts Randy.Dunlap
2005-03-14 19:38 ` Sam Ravnborg
2005-03-14 20:33 ` Keith Owens
2005-03-14 21:38 ` Randy.Dunlap
2005-03-14 21:40 ` Sam Ravnborg
2005-03-14 21:50 ` Randy.Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox