From: "Randy.Dunlap" <rddunlap@osdl.org>
To: maximilian attems <janitor@sternwelten.at>
Cc: lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>
Subject: Re: [patch] w6692 eliminate bad section references
Date: Mon, 14 Mar 2005 14:19:17 -0800 [thread overview]
Message-ID: <42360DE5.3000600@osdl.org> (raw)
In-Reply-To: <20050313230639.GA24301@sputnik.stro.at>
maximilian attems wrote:
> Fix w6692 section references:
> convert __initdata to __devinitdata.
>
> Error: ./drivers/isdn/hisax/w6692.o .text refers to 0000002f R_386_32
> .init.data
>
> Signed-off-by: maximilian attems <janitor@sternwelten.at>
>
>
> diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c
> linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c
> --- linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c 2005-03-02 08:38:25.000000000 +0100
> +++ linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c 2005-03-13 23:36:34.000000000 +0100
> @@ -45,7 +45,7 @@ const char *w6692_revision = "$Revision:
>
> #define DBUSY_TIMER_VALUE 80
>
> -static char *W6692Ver[] __initdata =
> +static char *W6692Ver[] __devinitdata =
> {"W6692 V00", "W6692 V01", "W6692 V10",
> "W6692 V11"};
>
I think the correct fix is to make W6692Version() be __init ...
What do you think of that?
--
~Randy
next prev parent reply other threads:[~2005-03-14 22:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-13 23:06 [patch] w6692 eliminate bad section references maximilian attems
2005-03-14 22:19 ` Randy.Dunlap [this message]
2005-03-15 13:39 ` maximilian attems
2005-03-15 15:40 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42360DE5.3000600@osdl.org \
--to=rddunlap@osdl.org \
--cc=akpm@osdl.org \
--cc=janitor@sternwelten.at \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox