From: "Randy.Dunlap" <rddunlap@osdl.org>
To: maximilian attems <janitor@sternwelten.at>
Cc: lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>
Subject: Re: [patch] w6692 eliminate bad section references
Date: Tue, 15 Mar 2005 07:40:04 -0800 [thread overview]
Message-ID: <423701D4.3000607@osdl.org> (raw)
In-Reply-To: <20050315133930.GC6680@sputnik.stro.at>
maximilian attems wrote:
>
> thanks a lot for your review!
> you are right much better, added __init to W6692Version().
>
> #Signed-off-by: maximilian attems <janitor@sternwelten.at>
Acked-by: Randy Dunlap <rddunlap@osdl.org>
> diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c
> linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c
> --- linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c 2005-03-02 08:38:25.000000000 +0100
> +++ linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c 2005-03-15 14:01:14.000000000 +0100
> @@ -49,7 +49,7 @@ static char *W6692Ver[] __initdata =
> {"W6692 V00", "W6692 V01", "W6692 V10",
> "W6692 V11"};
>
> -static void
> +static void __init
> W6692Version(struct IsdnCardState *cs, char *s)
> {
> int val;
--
~Randy
prev parent reply other threads:[~2005-03-15 15:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-13 23:06 [patch] w6692 eliminate bad section references maximilian attems
2005-03-14 22:19 ` Randy.Dunlap
2005-03-15 13:39 ` maximilian attems
2005-03-15 15:40 ` Randy.Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=423701D4.3000607@osdl.org \
--to=rddunlap@osdl.org \
--cc=akpm@osdl.org \
--cc=janitor@sternwelten.at \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox