* [patch] w6692 eliminate bad section references
@ 2005-03-13 23:06 maximilian attems
2005-03-14 22:19 ` Randy.Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: maximilian attems @ 2005-03-13 23:06 UTC (permalink / raw)
To: lkml; +Cc: Randy.Dunlap, akpm
Fix w6692 section references:
convert __initdata to __devinitdata.
Error: ./drivers/isdn/hisax/w6692.o .text refers to 0000002f R_386_32
.init.data
Signed-off-by: maximilian attems <janitor@sternwelten.at>
diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c
linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c
--- linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c 2005-03-02 08:38:25.000000000 +0100
+++ linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c 2005-03-13 23:36:34.000000000 +0100
@@ -45,7 +45,7 @@ const char *w6692_revision = "$Revision:
#define DBUSY_TIMER_VALUE 80
-static char *W6692Ver[] __initdata =
+static char *W6692Ver[] __devinitdata =
{"W6692 V00", "W6692 V01", "W6692 V10",
"W6692 V11"};
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] w6692 eliminate bad section references
2005-03-13 23:06 [patch] w6692 eliminate bad section references maximilian attems
@ 2005-03-14 22:19 ` Randy.Dunlap
2005-03-15 13:39 ` maximilian attems
0 siblings, 1 reply; 4+ messages in thread
From: Randy.Dunlap @ 2005-03-14 22:19 UTC (permalink / raw)
To: maximilian attems; +Cc: lkml, akpm
maximilian attems wrote:
> Fix w6692 section references:
> convert __initdata to __devinitdata.
>
> Error: ./drivers/isdn/hisax/w6692.o .text refers to 0000002f R_386_32
> .init.data
>
> Signed-off-by: maximilian attems <janitor@sternwelten.at>
>
>
> diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c
> linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c
> --- linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c 2005-03-02 08:38:25.000000000 +0100
> +++ linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c 2005-03-13 23:36:34.000000000 +0100
> @@ -45,7 +45,7 @@ const char *w6692_revision = "$Revision:
>
> #define DBUSY_TIMER_VALUE 80
>
> -static char *W6692Ver[] __initdata =
> +static char *W6692Ver[] __devinitdata =
> {"W6692 V00", "W6692 V01", "W6692 V10",
> "W6692 V11"};
>
I think the correct fix is to make W6692Version() be __init ...
What do you think of that?
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] w6692 eliminate bad section references
2005-03-14 22:19 ` Randy.Dunlap
@ 2005-03-15 13:39 ` maximilian attems
2005-03-15 15:40 ` Randy.Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: maximilian attems @ 2005-03-15 13:39 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: lkml, akpm
On Mon, 14 Mar 2005, Randy.Dunlap wrote:
> maximilian attems wrote:
> >Fix w6692 section references:
> > convert __initdata to __devinitdata.
> >
> >Error: ./drivers/isdn/hisax/w6692.o .text refers to 0000002f R_386_32
> >.init.data
> >
> I think the correct fix is to make W6692Version() be __init ...
> What do you think of that?
>
> --
> ~Randy
thanks a lot for your review!
you are right much better, added __init to W6692Version().
#Signed-off-by: maximilian attems <janitor@sternwelten.at>
diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c
linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c
--- linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c 2005-03-02 08:38:25.000000000 +0100
+++ linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c 2005-03-15 14:01:14.000000000 +0100
@@ -49,7 +49,7 @@ static char *W6692Ver[] __initdata =
{"W6692 V00", "W6692 V01", "W6692 V10",
"W6692 V11"};
-static void
+static void __init
W6692Version(struct IsdnCardState *cs, char *s)
{
int val;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] w6692 eliminate bad section references
2005-03-15 13:39 ` maximilian attems
@ 2005-03-15 15:40 ` Randy.Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy.Dunlap @ 2005-03-15 15:40 UTC (permalink / raw)
To: maximilian attems; +Cc: lkml, akpm
maximilian attems wrote:
>
> thanks a lot for your review!
> you are right much better, added __init to W6692Version().
>
> #Signed-off-by: maximilian attems <janitor@sternwelten.at>
Acked-by: Randy Dunlap <rddunlap@osdl.org>
> diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c
> linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c
> --- linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c 2005-03-02 08:38:25.000000000 +0100
> +++ linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c 2005-03-15 14:01:14.000000000 +0100
> @@ -49,7 +49,7 @@ static char *W6692Ver[] __initdata =
> {"W6692 V00", "W6692 V01", "W6692 V10",
> "W6692 V11"};
>
> -static void
> +static void __init
> W6692Version(struct IsdnCardState *cs, char *s)
> {
> int val;
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-03-15 15:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-13 23:06 [patch] w6692 eliminate bad section references maximilian attems
2005-03-14 22:19 ` Randy.Dunlap
2005-03-15 13:39 ` maximilian attems
2005-03-15 15:40 ` Randy.Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox