From: Phillip Lougher <phillip@lougher.demon.co.uk>
To: Matt Mackall <mpm@selenic.com>
Cc: Paul Jackson <pj@engr.sgi.com>,
Nick Piggin <nickpiggin@yahoo.com.au>,
akpm@osdl.org, linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [PATCH][1/2] SquashFS
Date: Tue, 15 Mar 2005 16:19:32 +0000 [thread overview]
Message-ID: <42370B14.50608@lougher.demon.co.uk> (raw)
In-Reply-To: <20050315172724.GO32638@waste.org>
Matt Mackall wrote:
> On Tue, Mar 15, 2005 at 03:50:26PM +0000, Phillip Lougher wrote:
>
>>Paul Jackson wrote:
>>
>>>In the overall kernel (Linus's bk tree) I count:
>>>
>>> 733 lines matching 'for *( *; *; *)'
>>> 718 lines matching 'while *( *1 *)'
>>>
>>>In the kernel/*.c files, I count 15 of the 'for(;;)' style and 1 of the
>>>'while(1)' style.
>>>
>>>Certainly the 'for(;;)' style is acceptable, and even slightly to
>>>substantially dominant, depending on which piece of code you're in.
>>>
>>
>>I prefer the 'while' style, and only used 'for' because that's what I
>>thought the kernel used.
>>
>>If no-one objects I'll change it back to while...
>>
>>Shouldn't issues like this be in the coding style document?
>
>
> This particular point is rather trivial. Do whatever suits you.
>
It's a shame the 'rather trivial' issue got picked up in the first place
then :-) I didn't raise the issue.
next prev parent reply other threads:[~2005-03-15 17:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-14 16:24 [PATCH][1/2] SquashFS Phillip Lougher
2005-03-15 0:38 ` Matt Mackall
2005-03-15 1:47 ` Nick Piggin
2005-03-15 2:33 ` Matt Mackall
2005-03-15 8:47 ` Paul Jackson
2005-03-15 15:50 ` Phillip Lougher
2005-03-15 17:27 ` Matt Mackall
2005-03-15 16:19 ` Phillip Lougher [this message]
2005-03-15 19:06 ` Paul Jackson
2005-03-16 1:50 ` Junio C Hamano
2005-03-16 7:14 ` Paul Jackson
2005-03-17 20:06 ` jerome lacoste
2005-03-15 0:51 ` Andrew Morton
2005-03-19 1:56 ` Kmap_atomic vs Kmap Phillip Lougher
2005-03-19 3:41 ` Andrew Morton
2005-03-20 23:11 ` Function stack size usage (was [PATCH][1/2] SquashFS) Phillip Lougher
2005-03-21 0:59 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42370B14.50608@lougher.demon.co.uk \
--to=phillip@lougher.demon.co.uk \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=nickpiggin@yahoo.com.au \
--cc=pj@engr.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox