* [PATCH][2.6.11] drivers/net/depca.c gcc4 fix
@ 2005-03-15 14:08 Mikael Pettersson
2005-03-15 17:15 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Mikael Pettersson @ 2005-03-15 14:08 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-net
Fix
drivers/net/depca.c: In function 'load_packet':
drivers/net/depca.c:1829: warning: operation on 'i' may be undefined
warning from gcc4 in depca.c.
/Mikael
--- linux-2.6.11/drivers/net/depca.c.~1~ 2005-03-02 19:24:16.000000000 +0100
+++ linux-2.6.11/drivers/net/depca.c 2005-03-15 14:36:49.000000000 +0100
@@ -1826,7 +1826,7 @@ static int load_packet(struct net_device
/* set up the buffer descriptors */
len = (skb->len < ETH_ZLEN) ? ETH_ZLEN : skb->len;
- for (i = entry; i != end; i = (++i) & lp->txRingMask) {
+ for (i = entry; i != end; i = (i+1) & lp->txRingMask) {
/* clean out flags */
writel(readl(&lp->tx_ring[i].base) & ~T_FLAGS, &lp->tx_ring[i].base);
writew(0x0000, &lp->tx_ring[i].misc); /* clears other error flags */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][2.6.11] drivers/net/depca.c gcc4 fix
2005-03-15 14:08 [PATCH][2.6.11] drivers/net/depca.c gcc4 fix Mikael Pettersson
@ 2005-03-15 17:15 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2005-03-15 17:15 UTC (permalink / raw)
To: Mikael Pettersson; +Cc: linux-kernel, linux-net
Mikael Pettersson wrote:
> Fix
>
> drivers/net/depca.c: In function 'load_packet':
> drivers/net/depca.c:1829: warning: operation on 'i' may be undefined
I'm looking over these. Please CC future netdev patches to me and
netdev@oss.sgi.com.
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-03-15 17:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-15 14:08 [PATCH][2.6.11] drivers/net/depca.c gcc4 fix Mikael Pettersson
2005-03-15 17:15 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox