From: Arnd Bergmann <arnd@arndb.de>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v9 00/17] Re-introduce h8300 architecture
Date: Mon, 27 Apr 2015 11:11:28 +0200 [thread overview]
Message-ID: <4238542.6HRp7rHay7@wuerfel> (raw)
In-Reply-To: <1430112924-1134-1-git-send-email-ysato@users.sourceforge.jp>
On Monday 27 April 2015 14:35:07 Yoshinori Sato wrote:
> Hello.
> I will re-introducing h8300.
>
I've done one more pass through all of your code. Generally I think you
should at this point ask Stephen Rothwell to add your git tree to linux-next,
and not rewrite the patches any more but instead add patches on top to fix
the remaining issues.
My comments are in several areas:
- device initialization. This should be updated to use a more modern version
and replace the use of early_platform and static platform_device definitions.
- asm/io.h needs should be rethought
- header files that are functionally identical to the asm-generic variant
and could be replaced with a 'generic-y' Makefile statement
I think all of these should be addressed, but they are not big issues that
would stop you from merging the code in linux-4.2.
Arnd
next prev parent reply other threads:[~2015-04-27 9:11 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 5:35 [PATCH v9 00/17] Re-introduce h8300 architecture Yoshinori Sato
2015-04-27 5:35 ` [PATCH v9 01/17] h8300: Assembly headers Yoshinori Sato
2015-04-27 7:42 ` Tobias Klauser
2015-04-27 7:48 ` Arnd Bergmann
2015-04-27 9:26 ` Tobias Klauser
2015-04-27 9:33 ` Arnd Bergmann
2015-04-28 11:19 ` Yoshinori Sato
2015-04-27 8:40 ` Arnd Bergmann
2015-04-28 11:31 ` Yoshinori Sato
2015-04-27 5:35 ` [PATCH v9 02/17] h8300: UAPI headers Yoshinori Sato
2015-04-27 8:43 ` Arnd Bergmann
2015-04-28 9:25 ` Yoshinori Sato
2015-04-27 5:35 ` [PATCH v9 03/17] h8300: Exception and Interrupt handling Yoshinori Sato
2015-04-27 5:35 ` [PATCH v9 04/17] h8300: kernel booting Yoshinori Sato
2015-04-27 5:35 ` [PATCH v9 05/17] h8300: process and signals Yoshinori Sato
2015-04-27 5:35 ` [PATCH v9 06/17] h8300: CPU depend helpers Yoshinori Sato
2015-04-27 8:54 ` Arnd Bergmann
2015-04-28 9:22 ` Yoshinori Sato
2015-04-27 5:35 ` [PATCH v9 07/17] h8300: miscellaneous functions Yoshinori Sato
2015-04-27 8:57 ` Arnd Bergmann
2015-04-28 8:54 ` Yoshinori Sato
2015-04-27 5:35 ` [PATCH v9 08/17] h8300: Memory management Yoshinori Sato
2015-04-27 5:35 ` [PATCH v9 09/17] h8300: library functions Yoshinori Sato
2015-04-27 5:35 ` [PATCH v9 10/17] h8300: Build scripts Yoshinori Sato
2015-04-27 5:35 ` [PATCH v9 11/17] h8300: clock driver Yoshinori Sato
2015-04-27 9:04 ` Arnd Bergmann
2015-04-28 9:43 ` Yoshinori Sato
2015-04-28 10:03 ` Geert Uytterhoeven
2015-04-28 17:40 ` Yoshinori Sato
2015-04-27 5:35 ` [PATCH v9 12/17] h8300: clocksource Yoshinori Sato
2015-04-27 5:35 ` [PATCH v9 13/17] h8300: configs Yoshinori Sato
2015-04-28 3:27 ` Guenter Roeck
2015-04-28 8:05 ` Yoshinori Sato
2015-04-27 5:35 ` [PATCH v9 14/17] serial: Add H8300 Yoshinori Sato
2015-04-29 16:47 ` [v9,14/17] " Guenter Roeck
2015-04-27 5:35 ` [PATCH v9 15/17] Add ELF machine Yoshinori Sato
2015-04-27 5:35 ` [PATCH v9 16/17] mksysmap: Add h8300 local symbol pattern Yoshinori Sato
2015-04-27 5:35 ` [PATCH v9 17/17] Add H8/300 entry Yoshinori Sato
2015-04-27 9:11 ` Arnd Bergmann [this message]
2015-04-28 9:09 ` [PATCH v9 00/17] Re-introduce h8300 architecture Yoshinori Sato
2015-04-28 13:22 ` Guenter Roeck
2015-04-28 17:25 ` Yoshinori Sato
2015-04-29 4:33 ` Guenter Roeck
2015-04-29 4:44 ` Guenter Roeck
2015-04-29 6:22 ` Yoshinori Sato
2015-04-29 13:24 ` Guenter Roeck
2015-04-29 17:07 ` Guenter Roeck
2015-04-30 3:50 ` Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4238542.6HRp7rHay7@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox