public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Dickman <didickman@yahoo.com>
To: linux-kernel@vger.kernel.org
Subject: question about build.c
Date: Mon, 21 Mar 2005 03:57:28 -0500	[thread overview]
Message-ID: <423E8C78.5040405@yahoo.com> (raw)

x86_64 checks if we're building a big kernel to make sure that it's <= 4MB. Should we be doing something similar for i386? Or perhaps we shouldn't be 
imposing this limit on x86_64?

Below is the relevant code diff that I'm asking about.

Thanks,
Daniel

--- linux-2.6.12-rc1-bk1/arch/i386/boot/tools/build.c   2005-03-02 02:38:09.000000000 -0500
+++ linux-2.6.12-rc1-bk1/arch/x86_64/boot/tools/build.c 2005-03-02 02:38:37.000000000 -0500
@@ -150,8 +150,10 @@
         sz = sb.st_size;
         fprintf (stderr, "System is %d kB\n", sz/1024);
         sys_size = (sz + 15) / 16;
-       if (!is_big_kernel && sys_size > DEF_SYSSIZE)
-               die("System is too big. Try using bzImage or modules.");
+       /* 0x40000*16 = 4.0 MB, reasonable estimate for the current maximum */
+       if (sys_size > (is_big_kernel ? 0x40000 : DEF_SYSSIZE))
+               die("System is too big. Try using %smodules.",
+                       is_big_kernel ? "" : "bzImage or ");
         while (sz > 0) {
                 int l, n;


                 reply	other threads:[~2005-03-21  8:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=423E8C78.5040405@yahoo.com \
    --to=didickman@yahoo.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox