public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH][2.6.11] drivers/net/arcnet/arcnet.c gcc4 fixes
@ 2005-03-15 14:05 Mikael Pettersson
  2005-03-22 22:52 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Mikael Pettersson @ 2005-03-15 14:05 UTC (permalink / raw)
  To: linux-kernel

Fix

drivers/net/arcnet/arcnet.c: In function 'release_arcbuf':
drivers/net/arcnet/arcnet.c:256: warning: operation on 'i' may be undefined
drivers/net/arcnet/arcnet.c: In function 'get_arcbuf':
drivers/net/arcnet/arcnet.c:292: warning: operation on 'i' may be undefined

warnings from gcc4 in arcnet.c.

/Mikael

--- linux-2.6.11/drivers/net/arcnet/arcnet.c.~1~	2005-03-02 19:24:16.000000000 +0100
+++ linux-2.6.11/drivers/net/arcnet/arcnet.c	2005-03-15 14:32:49.000000000 +0100
@@ -253,7 +253,7 @@ static void release_arcbuf(struct net_de
 	BUGLVL(D_DURING) {
 		BUGMSG(D_DURING, "release_arcbuf: freed #%d; buffer queue is now: ",
 		       bufnum);
-		for (i = lp->next_buf; i != lp->first_free_buf; i = ++i % 5)
+		for (i = lp->next_buf; i != lp->first_free_buf; i = (i+1) % 5)
 			BUGMSG2(D_DURING, "#%d ", lp->buf_queue[i]);
 		BUGMSG2(D_DURING, "\n");
 	}
@@ -289,7 +289,7 @@ static int get_arcbuf(struct net_device 
 
 	BUGLVL(D_DURING) {
 		BUGMSG(D_DURING, "get_arcbuf: got #%d; buffer queue is now: ", buf);
-		for (i = lp->next_buf; i != lp->first_free_buf; i = ++i % 5)
+		for (i = lp->next_buf; i != lp->first_free_buf; i = (i+1) % 5)
 			BUGMSG2(D_DURING, "#%d ", lp->buf_queue[i]);
 		BUGMSG2(D_DURING, "\n");
 	}

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH][2.6.11] drivers/net/arcnet/arcnet.c gcc4 fixes
  2005-03-15 14:05 [PATCH][2.6.11] drivers/net/arcnet/arcnet.c gcc4 fixes Mikael Pettersson
@ 2005-03-22 22:52 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2005-03-22 22:52 UTC (permalink / raw)
  To: Mikael Pettersson; +Cc: linux-kernel

applied.  but please:

1) include a signed-off-by line in all patches.

2) [administrivia] include the kernel version in the subject line like so:

	[patch 2.6.11] one-line summary...

See http://linux.yyz.us/patch-format.html for more info.

	Jeff




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-03-22 22:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-15 14:05 [PATCH][2.6.11] drivers/net/arcnet/arcnet.c gcc4 fixes Mikael Pettersson
2005-03-22 22:52 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox