Re: [PATCH scsi-misc-2.6 08/08] scsi: fix hot unplug sequence

James Bottomley
2005-03-23T15:12:37Z

On Wed, 2005-03-23 at 13:50 +0900, Tejun Heo wrote:
> Well, but it's because scsi midlayer calls back into usb-storage eh
> after the detaching process is complete.

Yes, but that's legitimate. It's always been explicitly stated that we
can't ensure absolute synchronisation in the stack: storage devices
must expect to have to reject I/O for devices they think have been
removed.

> > However, the current host code does need fixing, but the fix is to move
> > it over to a proper state model rather than the current bit twiddling we
> > do.
>
> I agree & am working on it. This patch was mainly to verify Jens' oops.

Thanks! You can look at the device state model as a guide ...
originally that was a bit mask too.

James