Re: [PATCH scsi-misc-2.6 04/08] scsi: remove meaningless volatile qualifiers from structure definitions

James Bottomley
2005-03-23T04:15:37Z

On Wed, 2005-03-23 at 11:14 +0900, Tejun Heo wrote:
> scsi_device->device_busy, Scsi_Host->host_busy and
> ->host_failed have volatile qualifiers, but the qualifiers
> don't serve any purpose. Kill them. While at it, protect
> ->host_failed update in scsi_error for consistency and clarity.

Well ... the data here is volatile so what you're advocating is a move
away from a volatile variable model to a protected variable one ... did
you audit all users of both of these to make sure we have protection on
all of them? It looks like the sata strategy handlers would still rely
on the volatile data.

James