From: Jeff Garzik <jgarzik@pobox.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: tulip-users@lists.sourceforge.net, linux-net@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/net/tulip/dmfe.c: fix check after use
Date: Thu, 24 Mar 2005 21:58:27 -0500 [thread overview]
Message-ID: <42437E53.5060708@pobox.com> (raw)
In-Reply-To: <20050325010315.GL3966@stusta.de>
Adrian Bunk wrote:
> This patch fixes a check after use found by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.12-rc1-mm1-full/drivers/net/tulip/dmfe.c.old 2005-03-23 05:05:36.000000000 +0100
> +++ linux-2.6.12-rc1-mm1-full/drivers/net/tulip/dmfe.c 2005-03-23 05:06:00.000000000 +0100
> @@ -736,20 +736,22 @@
>
> static irqreturn_t dmfe_interrupt(int irq, void *dev_id, struct pt_regs *regs)
> {
> struct DEVICE *dev = dev_id;
> struct dmfe_board_info *db = netdev_priv(dev);
> - unsigned long ioaddr = dev->base_addr;
> + unsigned long ioaddr;
> unsigned long flags;
>
> DMFE_DBUG(0, "dmfe_interrupt()", 0);
>
> if (!dev) {
> DMFE_DBUG(1, "dmfe_interrupt() without DEVICE arg", 0);
> return IRQ_NONE;
> }
I would prefer to remove the "if (!dev)" test, since it shouldn't ever
succeed.
Jeff
next prev parent reply other threads:[~2005-03-25 2:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-25 1:03 [2.6 patch] drivers/net/tulip/dmfe.c: fix check after use Adrian Bunk
2005-03-25 2:58 ` Jeff Garzik [this message]
2005-03-26 19:04 ` [2.6 patch] drivers/net/tulip/dmfe.c: remove a " Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42437E53.5060708@pobox.com \
--to=jgarzik@pobox.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=tulip-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox