public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Matthew Collins <matt@signalz.com>
Cc: Bernard Blackham <bernard@blackham.com.au>, linux-kernel@vger.kernel.org
Subject: Re: Promise SX8 performance issues and CARM_MAX_Q
Date: Thu, 24 Mar 2005 23:09:17 -0500	[thread overview]
Message-ID: <42438EED.4020202@pobox.com> (raw)
In-Reply-To: <4241FAF9.1080702@signalz.com>

Matthew Collins wrote:
> Jeff Garzik wrote:
> 
>> Bernard Blackham wrote:
>>
>>> Hi,
>>>
>>> Playing with a recently acquired Promise SX8 card, we've found
>>> similar performance results to Matt's post to lkml a few months back
>>> at http://marc.theaimsgroup.com/?l=linux-kernel&m=110175890323356&w=2
>>>
>>> It appears that the driver is only submitting one command at a time
>>> per port, which is at least one cause of the slowdowns. By raising
>>> CARM_MAX_Q from 1 to 3 in drivers/block/sx8.c (it was 3 in an
>>> earlier pre-merge incarnation of carmel.c), we're getting very
>>> notable speed improvements, with no side effects just yet.
>>>
>>> Knowing very little about what this change has actually done, I've a
>>> few questions:
>>>  - Should this be considered dangerous?
>>>  - Why was it taken from 3 to 1?
>>>  - Is CARM_MAX_Q a number defined (or limited) by the hardware?
>>
>>
>>
>> In multi-port stress tests, we couldn't get SX8 to function reliably 
>> without locking up or corrupting data, with more than one outstanding 
>> command.
>>
>> Maybe a new firmware has solved this by now.
>>
>>     Jeff
>>
>>
>>
> Indeed there does seem to be new firmware out as of 2/23/05. I ran my 
> tests with the 9/10/04 firmware but I did not adjust the CARM_MAX_Q 
> value. Do either of you happen to know what firmware revisions you 
> tested under?
> 
> I've put the machine with the SX8 controller into production despite the 
> performance issues so I'm not going to be of any use for testing 
> revisions to the driver :(

The driver was developed on a pre-production board, so its entirely 
possible Promise fixed this issue.

The driver should be solid for _at least_ CARM_MAX_Q==31, presuming that 
the firmware doesn't choke.

Anybody willing to
(a) change CARM_MAX_Q
(b) use the latest firmware
(c) stress the card with fsx, badblocks, iozone, and other tools
     on -multiple ports- simultaneously.

?

	Jeff




  reply	other threads:[~2005-03-25  4:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-29 19:50 Promise SX8 driver performance Matt
2005-03-23 17:57 ` Promise SX8 performance issues and CARM_MAX_Q Bernard Blackham
2005-03-23 23:16   ` Jeff Garzik
2005-03-23 23:25     ` Matthew Collins
2005-03-25  4:09       ` Jeff Garzik [this message]
2005-03-25  4:47         ` Bernard Blackham
2005-03-26 14:12         ` Bernard Blackham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42438EED.4020202@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=bernard@blackham.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@signalz.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox