From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932214AbcELMEn (ORCPT ); Thu, 12 May 2016 08:04:43 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:63625 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752010AbcELMEl (ORCPT ); Thu, 12 May 2016 08:04:41 -0400 From: Arnd Bergmann To: Michal Hocko Cc: Andrew Morton , Mel Gorman , Vlastimil Babka , David Rientjes , Joonsoo Kim , Taku Izumi , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm, compaction: avoid uninitialized variable use Date: Thu, 12 May 2016 14:04:10 +0200 Message-ID: <4247828.QFzDnOkjoa@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160512061636.GA4200@dhcp22.suse.cz> References: <1462973126-1183468-1-git-send-email-arnd@arndb.de> <20160512061636.GA4200@dhcp22.suse.cz> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:8MCw+Nr8wDxnE3ShZ0JXprJC3V+UCNBQ3x5JBokCaIrqvyqkw47 kyAQvujOhNXQxAW0MMa0xR2Knme9D7NfSBm6M0XuQLaZfxGFwJKAzm58DcZYFRdWR/x0jrk CE9NSGmdiP1L27mwXN29rL1ISu0XbhMi7Ckpp7z8koWW65Rgr4fVKG9uGkoSYozI6lA809I nLcNbqMdKAQkCOyzEM80w== X-UI-Out-Filterresults: notjunk:1;V01:K0:UzdhYcsMkjI=:ahW65PzFk4FB0maQPLFw59 mvz7/GZBKU8XWTu5H+R189qSHikCWJCFXkMSd9UXpdaOAYYNqUbQuObLPkTjD2Vgz5w1h35q8 WtVGl8UaMLnwpOtmu+3mbvOcIptFtWF/WdPLreFtoPV2Pv3Fm/WtbUtUR/fmcY0I8F0Rn24bC b1EU4wad5EHyn+L8D5bU8S/VCnR9kIuVSe1deWyhqTlGA75aHoyduQCcuChqKL6JnUOnkB4VY zttLDHr/+F6TUKu1W4wETzs33v8PdmVRFjkKhd/Ix2SyksYKHDxueKrutmqaxnrw0ssNaQhTG hKC5PYTtqUhix0/25BYfCNkJjOdwmooZu4wdyDUBqHlIN1U4I21K5GtyvNiQSbygDWfJulI5S VSH41u3UwvsR4TLmQ9h4gqr9AYivBrFMNxVLUf0CVfNe6cm2lxlVY1wbnOFPpYwwBwbuHMytN GVtPFzk3t2qQIolqDBf4+D9UCVWnDfR6DVLcrCrmhuL3V57rm74hGO2uk2SYYHKF4QSGGeFId XeNbYH/3gXVzq0GgkJph9bbIdg/NJpxF/WsbG1bPR/B3mEF5ZZ6Z6IloSwsT/AQhpWGpM0/5O J/diZkN/xkSSe/5+f0OureX8Hi4Og1a5pQT4AP9+JW0ydemrskLX4ldT/tKSBGV7OEYex+qwG FBr6c3AEJJDizvms77KCqik6YINB+nojjjQDEE4JldAhM1jEwPeTaRLg1LDvB/xoopVrs6LS6 4hmUmUUaE0uvAQRk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 12 May 2016 08:16:36 Michal Hocko wrote: > I think this would be slightly better than your proposal. Andrew, could > you fold it into the original > mm-compaction-simplify-__alloc_pages_direct_compact-feedback-interface.patch > patch? > --- > From 434bc8b6f3787724327499998c4fe651e8ce5d68 Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Thu, 12 May 2016 08:10:33 +0200 > Subject: [PATCH] mmotm: > mm-compaction-simplify-__alloc_pages_direct_compact-feedback-interface-fix > > Arnd has reported the following compilation warning: > mm/page_alloc.c: In function '__alloc_pages_nodemask': > mm/page_alloc.c:3651:6: error: 'compact_result' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > This should be a false positive TRANSPARENT_HUGEPAGE depends on COMPACTION > so is_thp_gfp_mask shouldn't be true. GFP_TRANSHUGE is a bit tricky > and somebody might be using this accidently. Make sure that compact_result > is defined also for !CONFIG_COMPACT and set it to COMPACT_SKIPPED because > the compaction was really withdrawn. > > Reported-by: Arnd Bergmann > Signed-off-by: Michal Hocko > Acked-by: Arnd Bergmann Looks much nicer than my version. Arnd