public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Brice Goglin <Brice.Goglin@ens-lyon.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] radeonfb: Fix mode setting on CRT monitors
Date: Mon, 28 Mar 2005 14:03:54 +0200	[thread overview]
Message-ID: <4247F2AA.7070201@ens-lyon.org> (raw)
In-Reply-To: <1111969496.5409.40.camel@gaston>

Benjamin Herrenschmidt a écrit :
> Hi !
> 
> Current radeonfb is a bit "anal" about accepting CRT modes, it basically only
> accepts modes that have the exact resolution, which tends to break with fbcon
> on console switches as it provides "approximate" modes. This patch fixes it
> by having the driver chose the closest possible mode instead of looking for
> an exact match.

Hi Benjamin,

I tried your patch because on recent -mm kernels I see dirty colored 
columns during a few seconds when switching from X to radeon fbcon
(looks like remaining colors of X).
I don't know what visible effect your patch is supposed to have.
I didn't see any difference, but I doesn't seem to break anything.

Regards,
Brice

  reply	other threads:[~2005-03-28 12:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-28  0:24 [PATCH] radeonfb: Fix mode setting on CRT monitors Benjamin Herrenschmidt
2005-03-28 12:03 ` Brice Goglin [this message]
2005-03-28 22:37   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4247F2AA.7070201@ens-lyon.org \
    --to=brice.goglin@ens-lyon.org \
    --cc=akpm@osdl.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox