From: "H. Peter Anvin" <hpa@zytor.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
jayalk@intworks.biz, linux-kernel@vger.kernel.org,
davej@codemonkey.org.uk
Subject: Re: [RFC 2.6.11.2 1/1] Add reboot fixup for gx1/cs5530a
Date: Mon, 28 Mar 2005 13:43:41 -0800 [thread overview]
Message-ID: <42487A8D.1040800@zytor.com> (raw)
In-Reply-To: <4248745A.2040409@zytor.com>
H. Peter Anvin wrote:
> Sam Ravnborg wrote:
>
>>
>> And hide this ifdef in same hederfile.
>>
>> #ifndef CONFIG_X86_REBOOTFIXUPS
>> #define mach_reboot_fixups do {} while (0);
>> #endif
>>
>
> No semicolon; besides:
>
> #define mach_reboot_fixups(x) ((void)0)
>
> ... is better all around.
>
Correction, that should have been:
#define mach_reboot_fixups(x) ((void)(x))
... in order to preserve side effects.
-hpa
prev parent reply other threads:[~2005-03-28 21:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-28 14:15 [RFC 2.6.11.2 1/1] Add reboot fixup for gx1/cs5530a jayalk
2005-03-28 14:36 ` H. Peter Anvin
2005-03-28 14:38 ` H. Peter Anvin
2005-03-28 17:27 ` Jesper Juhl
2005-03-28 21:17 ` Sam Ravnborg
2005-03-28 21:17 ` H. Peter Anvin
2005-03-28 21:43 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42487A8D.1040800@zytor.com \
--to=hpa@zytor.com \
--cc=davej@codemonkey.org.uk \
--cc=jayalk@intworks.biz \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox