From: Nick Piggin <nickpiggin@yahoo.com.au>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: Jens Axboe <axboe@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [patch] use cheaper elv_queue_empty when unplug a device
Date: Wed, 30 Mar 2005 10:57:49 +1000 [thread overview]
Message-ID: <4249F98D.9040706@yahoo.com.au> (raw)
In-Reply-To: <424928A1.8060400@yahoo.com.au>
Nick Piggin wrote:
> Jens Axboe wrote:
>
>> Looks good, I've been toying with something very similar for a long time
>> myself.
>>
>
> Here is another thing I just noticed that should further reduce the
> locking by at least 1, sometimes 2 lock/unlock pairs per request.
> At the cost of uglifying the code somewhat. Although it is pretty
> nicely contained, so Jens you might consider it acceptable as is,
> or we could investigate how to make it nicer if Kenneth reports some
> improvement.
>
> Note, this isn't runtime tested - it could easily have a bug.
>
OK - I have booted this on a 4-way SMP with SCSI disks, and done
some IO tests, and no hangs.
So Kenneth if you could look into this one as well, to see if
it is worthwhile, that would be great.
next prev parent reply other threads:[~2005-03-30 0:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-29 2:53 [patch] use cheaper elv_queue_empty when unplug a device Chen, Kenneth W
2005-03-29 8:06 ` Jens Axboe
2005-03-29 9:19 ` Nick Piggin
2005-03-29 9:21 ` Nick Piggin
2005-03-29 9:28 ` Jens Axboe
2005-03-29 9:50 ` Nick Piggin
2005-03-29 10:06 ` Nick Piggin
2005-03-30 0:57 ` Nick Piggin [this message]
2005-03-30 8:11 ` Jens Axboe
2005-04-08 9:45 ` Jens Axboe
2005-04-08 9:55 ` Nick Piggin
2005-04-08 10:02 ` Jens Axboe
2005-04-08 10:22 ` Nick Piggin
2005-03-29 10:10 ` Arjan van de Ven
2005-03-29 10:19 ` Jens Axboe
2005-03-29 10:23 ` Nick Piggin
2005-03-29 13:15 ` Jens Axboe
2005-03-30 0:07 ` Nick Piggin
2005-03-29 19:02 ` Chen, Kenneth W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4249F98D.9040706@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=axboe@suse.de \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox