Re: [PATCH] quiet ide-cd warning

[Michael Tokarev <mjt@tls.msk.ru>]

Matt Mackall wrote:
> This shuts up a potential uninitialized variable warning.

Potential warning or potential uninitialized use?
The code was right before the change, and if the compiler
generates such a warning on it, it's the compiler who
should be fixed, not the code: it's obvious the variable
can't be used uninitialized here, and moving the things
around like that makes the code misleading and hard to
understand...

/mjt

> Signed-off-by: Matt Mackall <mpm@selenic.com>
> 
> Index: af/drivers/ide/ide-cd.c
> ===================================================================
> --- af.orig/drivers/ide/ide-cd.c	2005-04-01 11:17:37.000000000 -0800
> +++ af/drivers/ide/ide-cd.c	2005-04-01 11:55:09.000000000 -0800
> @@ -430,7 +430,7 @@ void cdrom_analyze_sense_data(ide_drive_
>  #if VERBOSE_IDE_CD_ERRORS
>  	{
>  		int i;
> -		const char *s;
> +		const char *s = "bad sense key!";
>  		char buf[80];
>  
>  		printk ("ATAPI device %s:\n", drive->name);
> @@ -445,8 +445,6 @@ void cdrom_analyze_sense_data(ide_drive_
>  
>  		if (sense->sense_key < ARY_LEN(sense_key_texts))
>  			s = sense_key_texts[sense->sense_key];
> -		else
> -			s = "bad sense key!";
>  
>  		printk("%s -- (Sense key=0x%02x)\n", s, sense->sense_key);
>  
>