public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Drake <dsd@gentoo.org>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] procfs: Fix hardlink counts for /proc/<PID>/task
Date: Sat, 02 Apr 2005 21:00:40 +0100	[thread overview]
Message-ID: <424EF9E8.8010302@gentoo.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

The current logic assumes that a /proc/<PID>/task directory should have a 
hardlink count of 3, probably counting ".", "..", and a directory for a single 
child task.

It's fairly obvious that this doesn't work out correctly when a PID has more 
than one child task, which is quite often the case.

This should fix it up.

Signed-off-by: Daniel Drake <dsd@gentoo.org>

[-- Attachment #2: procfs-task-hardlinks.patch --]
[-- Type: text/x-patch, Size: 998 bytes --]

--- base.c.orig	2005-04-02 20:47:10.000000000 +0100
+++ base.c	2005-04-02 20:51:43.000000000 +0100
@@ -1337,6 +1337,8 @@
 static struct inode_operations proc_tgid_attr_inode_operations;
 #endif
 
+static int get_tid_list(int index, unsigned int *tids, struct inode *dir);
+
 /* SMP-safe */
 static struct dentry *proc_pident_lookup(struct inode *dir, 
 					 struct dentry *dentry,
@@ -1376,7 +1378,7 @@
 	 */
 	switch(p->type) {
 		case PROC_TGID_TASK:
-			inode->i_nlink = 3;
+			inode->i_nlink = 2 + get_tid_list(2, NULL, dir);
 			inode->i_op = &proc_task_inode_operations;
 			inode->i_fop = &proc_task_operations;
 			break;
@@ -1845,7 +1847,8 @@
 
 		if (--index >= 0)
 			continue;
-		tids[nr_tids] = tid;
+		if (tids != NULL)
+			tids[nr_tids] = tid;
 		nr_tids++;
 		if (nr_tids >= PROC_MAXPIDS)
 			break;
@@ -1945,6 +1948,7 @@
 	}
 
 	nr_tids = get_tid_list(pos, tid_array, inode);
+	inode->i_nlink = pos + nr_tids;
 
 	for (i = 0; i < nr_tids; i++) {
 		unsigned long j = PROC_NUMBUF;

             reply	other threads:[~2005-04-02 20:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-02 20:00 Daniel Drake [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-04-02 20:03 [PATCH] procfs: Fix hardlink counts for /proc/<PID>/task Daniel Drake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=424EF9E8.8010302@gentoo.org \
    --to=dsd@gentoo.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox