public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dag Arne Osvik <da@osvik.no>
To: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, linux-kernel@vger.kernel.org
Subject: Re: Use of C99 int types
Date: Mon, 04 Apr 2005 01:03:33 +0200	[thread overview]
Message-ID: <42507645.6010808@osvik.no> (raw)
In-Reply-To: <20050403181318.GW8859@parcelfarce.linux.theplanet.co.uk>

Al Viro wrote:

>On Sun, Apr 03, 2005 at 02:30:11PM +0200, Dag Arne Osvik wrote:
>  
>
>>Yes, but wouldn't it be much better to avoid code like the following, 
>>which may also be wrong (in terms of speed)?
>>
>>#ifdef CONFIG_64BIT  // or maybe CONFIG_X86_64?
>> #define fast_u32 u64
>>#else
>> #define fast_u32 u32
>>#endif
>>    
>>
>
>... and with such name 99% will assume (at least at the first reading)
>that it _is_ 32bits.  We have more than enough portability bugs as it
>is, no need to invite more by bad names.
>  
>

Agreed.  The way I see it there are two reasonable options.  One is to 
just use u32, which is always correct but sacrifices speed (at least 
with the current gcc).  The other is to introduce C99 types, which Linus 
doesn't seem to object to when they are kept away from interfaces 
(http://infocenter.guardiandigital.com/archive/linux-kernel/2004/Dec/0117.html).

-- 
  Dag Arne


  reply	other threads:[~2005-04-03 23:03 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-03 11:55 Use of C99 int types Dag Arne Osvik
2005-04-03 12:05 ` Stephen Rothwell
2005-04-03 12:30   ` Dag Arne Osvik
2005-04-03 13:27     ` Andreas Schwab
2005-04-03 22:48       ` Dag Arne Osvik
2005-04-03 23:05         ` Al Viro
2005-04-03 23:17         ` Grzegorz Kulewski
2005-04-03 23:20           ` Dag Arne Osvik
2005-04-04  0:05         ` Adrian Bunk
2005-04-03 18:13     ` Al Viro
2005-04-03 23:03       ` Dag Arne Osvik [this message]
2005-04-04  3:08         ` Herbert Xu
2005-04-04  8:42           ` Dag Arne Osvik
2005-04-03 19:23     ` Renate Meijer
2005-04-03 20:25       ` Kenneth Johansson
2005-04-03 22:08         ` Kyle Moffett
2005-04-04 10:05           ` Renate Meijer
2005-04-04 10:50             ` Dag Arne Osvik
2005-04-04 20:30               ` Renate Meijer
2005-04-04 20:57                 ` Al Viro
2005-04-04 21:25                   ` Richard B. Johnson
2005-04-04 21:49                     ` Kyle Moffett
2005-04-05  9:23                       ` Renate Meijer
2005-04-05 11:27                         ` Kyle Moffett
     [not found]                           ` <09142f748cc6ad2bf4fffab7a5519226@xs4all.nl>
2005-04-05 22:11                             ` Kyle Moffett
     [not found]                               ` <eb65bccddde63541ae4b7b2d6c4c32d3@xs4all.nl>
2005-04-06 21:11                                 ` Kyle Moffett
2005-04-07 11:28                                   ` Renate Meijer
2005-04-05 12:18                       ` Richard B. Johnson
2005-04-05 21:47                         ` Kyle Moffett
2005-04-05  8:49                   ` Renate Meijer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42507645.6010808@osvik.no \
    --to=da@osvik.no \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=viro@parcelfarce.linux.theplanet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox