[PATCH] I2C rtc8564.c remove duplicate include (fixed)

[PATCH] I2C rtc8564.c remove duplicate include (fixed)

[Clemens Koller]

[PATCH] I2C rtc8564.c remove duplicate include

Trivial fix: removes duplicate include line.

Patch applies to: 2.6.11.x

(This is my very first patch to the linux-kernel, so let me
start with small things first...)

Signed-off-by: Clemens Koller <clemens.koller@anagramm.de>


diff -Nur --exclude-from=dontdiff-osdl linux-2.6.11.6-clean/drivers/i2c/chips/rtc8564.c linux-2.6.11.6/drivers/i2c/chips/rtc8564.c
--- linux-2.6.11.6-clean/drivers/i2c/chips/rtc8564.c	2005-03-26 04:28:14.000000000 +0100
+++ linux-2.6.11.6/drivers/i2c/chips/rtc8564.c	2005-04-04 12:37:05.000000000 +0200
@@ -19,7 +19,6 @@
  #include <linux/string.h>
  #include <linux/rtc.h>		/* get the user-level API */
  #include <linux/init.h>
-#include <linux/init.h>

  #include "rtc8564.h"

Re: [PATCH] I2C rtc8564.c remove duplicate include (fixed)

[Jean Delvare]

Hi Clemens,

> [PATCH] I2C rtc8564.c remove duplicate include
> 
> Trivial fix: removes duplicate include line.
> 
> Patch applies to: 2.6.11.x
> 
> (This is my very first patch to the linux-kernel, so let me
> start with small things first...)
> 
> Signed-off-by: Clemens Koller <clemens.koller@anagramm.de>

There's nothing wrong with small things like that, but unfortunately
your patch is somehow malformed and won't apply. Maybe your e-mail
client broke it. Still I am interested in this clean up patch, so I
would appreciate if you could check what went wrong, fix it and send a
working patch.

Thanks,
-- 
Jean Delvare

Re: [PATCH] I2C rtc8564.c remove duplicate include (whitespace fixed)

[Clemens Koller]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

[PATCH] I2C rtc8564.c remove duplicate include

Trivial fix: removes duplicate include line.
Patch applies to: 2.6.11.x

(This is my very first patch to the linux-kernel, so let me
start with small things first...)

Signed-off-by: Clemens Koller <clemens.koller@anagramm.de>
---

[-- Attachment #2: rtc8564.diff --]
[-- Type: text/x-diff, Size: 478 bytes --]

diff -Nur --exclude-from=dontdiff-osdl linux-2.6.11.6-clean/drivers/i2c/chips/rtc8564.c linux-2.6.11.6/drivers/i2c/chips/rtc8564.c
--- linux-2.6.11.6-clean/drivers/i2c/chips/rtc8564.c	2005-03-26 04:28:14.000000000 +0100
+++ linux-2.6.11.6/drivers/i2c/chips/rtc8564.c	2005-04-04 12:37:05.000000000 +0200
@@ -19,7 +19,6 @@
 #include <linux/string.h>
 #include <linux/rtc.h>		/* get the user-level API */
 #include <linux/init.h>
-#include <linux/init.h>
 
 #include "rtc8564.h"
 

Re: [PATCH] I2C rtc8564.c remove duplicate include (whitespace fixed)

[Jean Delvare]

Hi Clemens,

> [PATCH] I2C rtc8564.c remove duplicate include
> 
> Trivial fix: removes duplicate include line.
> Patch applies to: 2.6.11.x
> 
> (This is my very first patch to the linux-kernel, so let me
> start with small things first...)
> 
> Signed-off-by: Clemens Koller <clemens.koller@anagramm.de>

Thanks for the patch, I added it to my stack. Greg, please pick it for
your i2c tree.

-- 
Jean Delvare

Re: [PATCH] I2C rtc8564.c remove duplicate include (whitespace fixed)

[Greg KH]

On Mon, Apr 11, 2005 at 11:49:14AM +0200, Clemens Koller wrote:
> [PATCH] I2C rtc8564.c remove duplicate include
> 
> Trivial fix: removes duplicate include line.
> Patch applies to: 2.6.11.x
> 
> (This is my very first patch to the linux-kernel, so let me
> start with small things first...)
> 
> Signed-off-by: Clemens Koller <clemens.koller@anagramm.de>

Applied, thanks.

greg k-h