* [PATCH] I2C rtc8564.c remove duplicate include (fixed)
@ 2005-04-04 11:33 Clemens Koller
2005-04-09 11:16 ` Jean Delvare
0 siblings, 1 reply; 5+ messages in thread
From: Clemens Koller @ 2005-04-04 11:33 UTC (permalink / raw)
To: linux-kernel
[PATCH] I2C rtc8564.c remove duplicate include
Trivial fix: removes duplicate include line.
Patch applies to: 2.6.11.x
(This is my very first patch to the linux-kernel, so let me
start with small things first...)
Signed-off-by: Clemens Koller <clemens.koller@anagramm.de>
diff -Nur --exclude-from=dontdiff-osdl linux-2.6.11.6-clean/drivers/i2c/chips/rtc8564.c linux-2.6.11.6/drivers/i2c/chips/rtc8564.c
--- linux-2.6.11.6-clean/drivers/i2c/chips/rtc8564.c 2005-03-26 04:28:14.000000000 +0100
+++ linux-2.6.11.6/drivers/i2c/chips/rtc8564.c 2005-04-04 12:37:05.000000000 +0200
@@ -19,7 +19,6 @@
#include <linux/string.h>
#include <linux/rtc.h> /* get the user-level API */
#include <linux/init.h>
-#include <linux/init.h>
#include "rtc8564.h"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] I2C rtc8564.c remove duplicate include (fixed)
2005-04-04 11:33 [PATCH] I2C rtc8564.c remove duplicate include (fixed) Clemens Koller
@ 2005-04-09 11:16 ` Jean Delvare
2005-04-11 9:49 ` [PATCH] I2C rtc8564.c remove duplicate include (whitespace fixed) Clemens Koller
0 siblings, 1 reply; 5+ messages in thread
From: Jean Delvare @ 2005-04-09 11:16 UTC (permalink / raw)
To: Clemens Koller; +Cc: linux-kernel
Hi Clemens,
> [PATCH] I2C rtc8564.c remove duplicate include
>
> Trivial fix: removes duplicate include line.
>
> Patch applies to: 2.6.11.x
>
> (This is my very first patch to the linux-kernel, so let me
> start with small things first...)
>
> Signed-off-by: Clemens Koller <clemens.koller@anagramm.de>
There's nothing wrong with small things like that, but unfortunately
your patch is somehow malformed and won't apply. Maybe your e-mail
client broke it. Still I am interested in this clean up patch, so I
would appreciate if you could check what went wrong, fix it and send a
working patch.
Thanks,
--
Jean Delvare
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] I2C rtc8564.c remove duplicate include (whitespace fixed)
2005-04-09 11:16 ` Jean Delvare
@ 2005-04-11 9:49 ` Clemens Koller
2005-04-11 22:10 ` Jean Delvare
2005-05-02 20:15 ` Greg KH
0 siblings, 2 replies; 5+ messages in thread
From: Clemens Koller @ 2005-04-11 9:49 UTC (permalink / raw)
To: Jean Delvare, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 279 bytes --]
[PATCH] I2C rtc8564.c remove duplicate include
Trivial fix: removes duplicate include line.
Patch applies to: 2.6.11.x
(This is my very first patch to the linux-kernel, so let me
start with small things first...)
Signed-off-by: Clemens Koller <clemens.koller@anagramm.de>
---
[-- Attachment #2: rtc8564.diff --]
[-- Type: text/x-diff, Size: 478 bytes --]
diff -Nur --exclude-from=dontdiff-osdl linux-2.6.11.6-clean/drivers/i2c/chips/rtc8564.c linux-2.6.11.6/drivers/i2c/chips/rtc8564.c
--- linux-2.6.11.6-clean/drivers/i2c/chips/rtc8564.c 2005-03-26 04:28:14.000000000 +0100
+++ linux-2.6.11.6/drivers/i2c/chips/rtc8564.c 2005-04-04 12:37:05.000000000 +0200
@@ -19,7 +19,6 @@
#include <linux/string.h>
#include <linux/rtc.h> /* get the user-level API */
#include <linux/init.h>
-#include <linux/init.h>
#include "rtc8564.h"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] I2C rtc8564.c remove duplicate include (whitespace fixed)
2005-04-11 9:49 ` [PATCH] I2C rtc8564.c remove duplicate include (whitespace fixed) Clemens Koller
@ 2005-04-11 22:10 ` Jean Delvare
2005-05-02 20:15 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Jean Delvare @ 2005-04-11 22:10 UTC (permalink / raw)
To: Clemens Koller, Greg KH; +Cc: LKML
Hi Clemens,
> [PATCH] I2C rtc8564.c remove duplicate include
>
> Trivial fix: removes duplicate include line.
> Patch applies to: 2.6.11.x
>
> (This is my very first patch to the linux-kernel, so let me
> start with small things first...)
>
> Signed-off-by: Clemens Koller <clemens.koller@anagramm.de>
Thanks for the patch, I added it to my stack. Greg, please pick it for
your i2c tree.
--
Jean Delvare
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] I2C rtc8564.c remove duplicate include (whitespace fixed)
2005-04-11 9:49 ` [PATCH] I2C rtc8564.c remove duplicate include (whitespace fixed) Clemens Koller
2005-04-11 22:10 ` Jean Delvare
@ 2005-05-02 20:15 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2005-05-02 20:15 UTC (permalink / raw)
To: Clemens Koller; +Cc: Jean Delvare, linux-kernel
On Mon, Apr 11, 2005 at 11:49:14AM +0200, Clemens Koller wrote:
> [PATCH] I2C rtc8564.c remove duplicate include
>
> Trivial fix: removes duplicate include line.
> Patch applies to: 2.6.11.x
>
> (This is my very first patch to the linux-kernel, so let me
> start with small things first...)
>
> Signed-off-by: Clemens Koller <clemens.koller@anagramm.de>
Applied, thanks.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-05-02 20:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-04 11:33 [PATCH] I2C rtc8564.c remove duplicate include (fixed) Clemens Koller
2005-04-09 11:16 ` Jean Delvare
2005-04-11 9:49 ` [PATCH] I2C rtc8564.c remove duplicate include (whitespace fixed) Clemens Koller
2005-04-11 22:10 ` Jean Delvare
2005-05-02 20:15 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox