public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 1/3] pnpbios eliminate bad section references
@ 2005-04-04 18:10 maximilian attems
  2005-04-04 19:56 ` Randy.Dunlap
  0 siblings, 1 reply; 3+ messages in thread
From: maximilian attems @ 2005-04-04 18:10 UTC (permalink / raw)
  To: lkml; +Cc: Randy.Dunlap, akpm

one of the last buildcheck errors on i386,
thanks Randy again for double checking.

Fix pnpbios section references:
make dmi_system_id pnpbios_dmi_table __initdata

Error: ./drivers/pnp/pnpbios/core.o .data refers to 00000100 R_386_32
.init.text
Error: ./drivers/pnp/pnpbios/core.o .data refers to 0000012c R_386_32
.init.text

Signed-off-by: maximilian attems <janitor@sternwelten.at>


--- linux-2.6.12-rc1-bk5/drivers/pnp/pnpbios/core.c.orig	2005-04-04 19:11:37.814477672 +0200
+++ linux-2.6.12-rc1-bk5/drivers/pnp/pnpbios/core.c	2005-04-04 19:25:50.074402365 +0200
@@ -512,7 +512,7 @@
 	return 0;
 }
 
-static struct dmi_system_id pnpbios_dmi_table[] = {
+static struct dmi_system_id pnpbios_dmi_table[] __initdata = {
 	{	/* PnPBIOS GPF on boot */
 		.callback = exploding_pnp_bios,
 		.ident = "Higraded P14H",

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch 1/3] pnpbios eliminate bad section references
  2005-04-04 18:10 [patch 1/3] pnpbios eliminate bad section references maximilian attems
@ 2005-04-04 19:56 ` Randy.Dunlap
  2005-04-04 23:04   ` Adam Belay
  0 siblings, 1 reply; 3+ messages in thread
From: Randy.Dunlap @ 2005-04-04 19:56 UTC (permalink / raw)
  To: maximilian attems; +Cc: lkml, akpm, ambx1

maximilian attems wrote:
> one of the last buildcheck errors on i386,
> thanks Randy again for double checking.
> 
> Fix pnpbios section references:
> make dmi_system_id pnpbios_dmi_table __initdata
> 
> Error: ./drivers/pnp/pnpbios/core.o .data refers to 00000100 R_386_32
> .init.text
> Error: ./drivers/pnp/pnpbios/core.o .data refers to 0000012c R_386_32
> .init.text
> 
> Signed-off-by: maximilian attems <janitor@sternwelten.at>
> 
> 
> --- linux-2.6.12-rc1-bk5/drivers/pnp/pnpbios/core.c.orig	2005-04-04 19:11:37.814477672 +0200
> +++ linux-2.6.12-rc1-bk5/drivers/pnp/pnpbios/core.c	2005-04-04 19:25:50.074402365 +0200
> @@ -512,7 +512,7 @@
>  	return 0;
>  }
>  
> -static struct dmi_system_id pnpbios_dmi_table[] = {
> +static struct dmi_system_id pnpbios_dmi_table[] __initdata = {
>  	{	/* PnPBIOS GPF on boot */
>  		.callback = exploding_pnp_bios,
>  		.ident = "Higraded P14H",

Looks OK to me, but I'd prefer to leave it up to Adam.....

-- 
~Randy



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch 1/3] pnpbios eliminate bad section references
  2005-04-04 19:56 ` Randy.Dunlap
@ 2005-04-04 23:04   ` Adam Belay
  0 siblings, 0 replies; 3+ messages in thread
From: Adam Belay @ 2005-04-04 23:04 UTC (permalink / raw)
  To: Randy.Dunlap; +Cc: maximilian attems, lkml, akpm

On Mon, Apr 04, 2005 at 12:56:32PM -0700, Randy.Dunlap wrote:
> maximilian attems wrote:
> >one of the last buildcheck errors on i386,
> >thanks Randy again for double checking.
> >
> >Fix pnpbios section references:
> >make dmi_system_id pnpbios_dmi_table __initdata
> >
> >Error: ./drivers/pnp/pnpbios/core.o .data refers to 00000100 R_386_32
> >.init.text
> >Error: ./drivers/pnp/pnpbios/core.o .data refers to 0000012c R_386_32
> >.init.text
> >
> >Signed-off-by: maximilian attems <janitor@sternwelten.at>
> >
> >
> >--- linux-2.6.12-rc1-bk5/drivers/pnp/pnpbios/core.c.orig	2005-04-04 
> >19:11:37.814477672 +0200
> >+++ linux-2.6.12-rc1-bk5/drivers/pnp/pnpbios/core.c	2005-04-04 
> >19:25:50.074402365 +0200
> >@@ -512,7 +512,7 @@
> > 	return 0;
> > }
> > 
> >-static struct dmi_system_id pnpbios_dmi_table[] = {
> >+static struct dmi_system_id pnpbios_dmi_table[] __initdata = {
> > 	{	/* PnPBIOS GPF on boot */
> > 		.callback = exploding_pnp_bios,
> > 		.ident = "Higraded P14H",
> 
> Looks OK to me, but I'd prefer to leave it up to Adam.....

Thank you for forwarding this to me.  It looks good.

Cheers,
Adam

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-04-04 23:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-04 18:10 [patch 1/3] pnpbios eliminate bad section references maximilian attems
2005-04-04 19:56 ` Randy.Dunlap
2005-04-04 23:04   ` Adam Belay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox